Subject: Re: [PATCH v6 04/11] Documentation: perf: hisi: Documentation for
 HiP05/06/07 PMU event counting.
To: Mark Rutland <mark.rutland@arm.com>
References: <1489127259-112648-1-git-send-email-anurup.m@huawei.com>
 <20170321141222.GE22188@leverpostej>
Cc: corbet@lwn.net, will.deacon@arm.com, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        anurup.m@huawei.com, zhangshaokun@hisilicon.com, tanxiaojun@huawei.com,
        xuwei5@hisilicon.com, sanil.kumar@hisilicon.com, john.garry@huawei.com,
        gabriele.paoloni@huawei.com, shiju.jose@huawei.com,
        huangdaode@hisilicon.com, linuxarm@huawei.com, dikshit.n@huawei.com,
        shyju.pv@huawei.com
From: Anurup M <anurupvasu@gmail.com>
Message-ID: <58D4BE38.1080003@gmail.com>
Date: Fri, 24 Mar 2017 12:05:36 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20170321141222.GE22188@leverpostej>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 508
Lines: 23

Thanks for the review.

On Tuesday 21 March 2017 07:42 PM, Mark Rutland wrote:
> Hi,
>
> On Fri, Mar 10, 2017 at 01:27:39AM -0500, Anurup M wrote:
>
>> +HiP0x chips are encapsulated by multiple CPU and IO die's. The CPU die is
> Nit: that apostrophe shouldn't be there.

Ok. shall recheck and modify wherever applicable.

> [...]
>
>> +The current driver doesnot support sampling. so "perf record" is unsupported.
> Nit: spacing
>
> Otherwise, this looked fine.

Thanks. shall correct it.

> Thanks,
> Mark.