Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753543AbdCXHdA (ORCPT ); Fri, 24 Mar 2017 03:33:00 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:35570 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543AbdCXHch (ORCPT ); Fri, 24 Mar 2017 03:32:37 -0400 MIME-Version: 1.0 In-Reply-To: <20170324072513.GL30608@dragon> References: <1490204897-14525-1-git-send-email-jagan@openedev.com> <1490204897-14525-6-git-send-email-jagan@openedev.com> <20170324051632.GD30608@dragon> <20170324072513.GL30608@dragon> From: Jagan Teki Date: Fri, 24 Mar 2017 13:02:35 +0530 Message-ID: Subject: Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node To: Shawn Guo Cc: Jagan Teki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel , Matteo Lisi , Michael Trimarchi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2791 Lines: 87 On Fri, Mar 24, 2017 at 12:55 PM, Shawn Guo wrote: > On Fri, Mar 24, 2017 at 12:29:49PM +0530, Jagan Teki wrote: >> On Fri, Mar 24, 2017 at 10:46 AM, Shawn Guo wrote: >> > On Wed, Mar 22, 2017 at 11:18:10PM +0530, Jagan Teki wrote: >> >> From: Jagan Teki >> >> >> >> Add touchscreen node as i2c1 slave device on Engicam Is.IoT MX6UL >> >> modules, the touchscreen controlled 'st,stmpe-ts' connected via >> >> i2c with st,stmpe811 mfb interface. >> > >> > s/mfb/mfd? >> > >> >> >> >> Cc: Shawn Guo >> >> Cc: Matteo Lisi >> >> Cc: Michael Trimarchi >> >> Signed-off-by: Jagan Teki >> >> --- >> >> arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 34 ++++++++++++++++++++++++++++++ >> >> 1 file changed, 34 insertions(+) >> >> >> >> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi >> >> index 9660e20..b149b5e 100644 >> >> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi >> >> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi >> >> @@ -40,6 +40,34 @@ >> >> * OTHER DEALINGS IN THE SOFTWARE. >> >> */ >> >> >> >> +&i2c1 { >> >> + touch: stmpe811@44 { >> > >> > Label a MFD device 'touch'? Also, the node name should be generic. Not >> > sure what should be used for MFD device though. >> >> May be I can use stmpe811@41 the existing imx6qdl-apalis.dtsi using >> the similar notation. > > Per application notes of stmpe811 below, I would suggest you name it > gpio-expander. > > www.st.com/resource/zh/datasheet/CD00186725.pdf OK, will this be ok? stmpe811: gpio-expander@44 { > >> >> > >> >> + compatible = "st,stmpe811"; >> >> + reg = <0x44>; >> >> + #address-cells = <1>; >> >> + #size-cells = <0>; >> >> + pinctrl-names = "default"; >> >> + pinctrl-0 = <&pinctrl_stmpe_ts>; >> > >> > If this is for stmpe-ts, shouldn't be put into touchscreen child node? >> >> Actually this is interrupt pad, for the touch controller via stmpe so >> I can rename pinctrl_touch_int. > > Or just pinctrl_stmpe. > >> >> > >> >> + interrupt-parent = <&gpio1>; >> >> + interrupts = <18 IRQ_TYPE_EDGE_FALLING>; >> >> + interrupt-controller; >> >> + #interrupt-cells = <2>; >> >> + >> >> + stmpe_touchscreen { >> > >> > 'stmpe: touchscreen {' might be better. >> >> stmpe_touchscreen { >> >> This is also compatible with existing dtsi files > > We do not need to keep compatibility with something not good. thanks! -- Jagan Teki Senior Linux Kernel Engineer | Amarula Solutions U-Boot, Linux | Upstream Maintainer Hyderabad, India.