Date: Fri, 24 Mar 2017 09:43:41 +0100
From: Greg KH <greg@kroah.com>
To: "Pranay Kr. Srivastava" <pranjas@gmail.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
        samuel.thibault@ens-lyon.org, sfr@canb.auug.org.au,
        speakup@linux-speakup.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as
 per required context
Message-ID: <20170324084341.GA10793@kroah.com>
References: <20170323131737.GA13629@kroah.com>
 <20170324083711.7920-1-pranjas@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170324083711.7920-1-pranjas@gmail.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 403
Lines: 16

On Fri, Mar 24, 2017 at 02:07:11PM +0530, Pranay Kr. Srivastava wrote:
> speakup_allocate used GFP_ATOMIC for allocations
> even while during initialization due to it's use
> in notifier call.

Is that a problem?

> Pass GFP_ flags as well to speakup_allocate depending
> on the context it is called in.

At init, we should be fine to use GFP_ATOMIC, so is this change really
needed?

thanks,

greg k-h