Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964974AbdCXI5v (ORCPT ); Fri, 24 Mar 2017 04:57:51 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:34640 "EHLO mail-io0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756681AbdCXI5c (ORCPT ); Fri, 24 Mar 2017 04:57:32 -0400 MIME-Version: 1.0 In-Reply-To: <1490239655-20902-3-git-send-email-bhe@redhat.com> References: <1490239655-20902-1-git-send-email-bhe@redhat.com> <1490239655-20902-3-git-send-email-bhe@redhat.com> From: Ard Biesheuvel Date: Fri, 24 Mar 2017 08:57:30 +0000 Message-ID: Subject: Re: [PATCH v1 RESEND 2/2] x86/efi: Clean up a minor mistake in code comment To: Baoquan He Cc: "linux-kernel@vger.kernel.org" , Matt Fleming , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , "x86@kernel.org" , "linux-efi@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1384 Lines: 41 On 23 March 2017 at 03:27, Baoquan He wrote: > EFI allocate runtime services regions from EFI_VA_START, -4G, down > to -64G, EFI_VA_END. OK, so is the size of the region 60 GB or 64 GB? This suggests 60 GB, but the comment you update suggests 64 GB. > The mechanism was introduced in > commit d2f7cbe7b26a7 ("x86/efi: Runtime services virtual mapping"). > > Clean it up to avoid confusion. > > Signed-off-by: Baoquan He > Cc: Matt Fleming > Cc: Ard Biesheuvel > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Borislav Petkov > Cc: x86@kernel.org > Cc: linux-efi@vger.kernel.org > --- > arch/x86/platform/efi/efi_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c > index a4695da..6cbf9e0 100644 > --- a/arch/x86/platform/efi/efi_64.c > +++ b/arch/x86/platform/efi/efi_64.c > @@ -47,7 +47,7 @@ > #include > > /* > - * We allocate runtime services regions bottom-up, starting from -4G, i.e. > + * We allocate runtime services regions top-down, starting from -4G, i.e. > * 0xffff_ffff_0000_0000 and limit EFI VA mapping space to 64G. > */ > static u64 efi_va = EFI_VA_START; > -- > 2.5.5 >