Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965464AbdCXJEZ (ORCPT ); Fri, 24 Mar 2017 05:04:25 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:33576 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964987AbdCXJEM (ORCPT ); Fri, 24 Mar 2017 05:04:12 -0400 Date: Fri, 24 Mar 2017 12:04:08 +0300 From: "Kirill A. Shutemov" To: "Aneesh Kumar K.V" Cc: "Kirill A. Shutemov" , Linus Torvalds , Andrew Morton , x86@kernel.org, Thomas Gleixner , Ingo Molnar , Arnd Bergmann , "H. Peter Anvin" , Andi Kleen , Dave Hansen , Andy Lutomirski , Michal Hocko , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 26/26] x86/mm: allow to have userspace mappings above 47-bits Message-ID: <20170324090408.xsj7othssj547w5k@node.shutemov.name> References: <20170313055020.69655-1-kirill.shutemov@linux.intel.com> <20170313055020.69655-27-kirill.shutemov@linux.intel.com> <8760j4sfcz.fsf@skywalker.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8760j4sfcz.fsf@skywalker.in.ibm.com> User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1132 Lines: 33 On Mon, Mar 20, 2017 at 10:40:20AM +0530, Aneesh Kumar K.V wrote: > "Kirill A. Shutemov" writes: > @@ -168,6 +182,10 @@ arch_get_unmapped_area_topdown(struct file *filp, const unsigned long addr0, > > unsigned long addr = addr0; > > struct vm_unmapped_area_info info; > > > > + addr = mpx_unmapped_area_check(addr, len, flags); > > + if (IS_ERR_VALUE(addr)) > > + return addr; > > + > > /* requested length too big for entire address space */ > > if (len > TASK_SIZE) > > return -ENOMEM; > > @@ -192,6 +210,14 @@ arch_get_unmapped_area_topdown(struct file *filp, const unsigned long addr0, > > info.length = len; > > info.low_limit = PAGE_SIZE; > > info.high_limit = mm->mmap_base; > > + > > + /* > > + * If hint address is above DEFAULT_MAP_WINDOW, look for unmapped area > > + * in the full address space. > > + */ > > + if (addr > DEFAULT_MAP_WINDOW) > > + info.high_limit += TASK_SIZE - DEFAULT_MAP_WINDOW; > > + > > Is this ok for 32 bit application ? DEFAULT_MAP_WINDOW is equal to TASK_SIZE on 32-bit, so it's nop and will be compile out. -- Kirill A. Shutemov