Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965496AbdCXJEk (ORCPT ); Fri, 24 Mar 2017 05:04:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58550 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964974AbdCXJEf (ORCPT ); Fri, 24 Mar 2017 05:04:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A77A77E9FD Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=bhe@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A77A77E9FD Date: Fri, 24 Mar 2017 17:04:32 +0800 From: Baoquan He To: Ard Biesheuvel Cc: "linux-kernel@vger.kernel.org" , Matt Fleming , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , "x86@kernel.org" , "linux-efi@vger.kernel.org" Subject: Re: [PATCH v1 RESEND 2/2] x86/efi: Clean up a minor mistake in code comment Message-ID: <20170324090432.GD30442@x1> References: <1490239655-20902-1-git-send-email-bhe@redhat.com> <1490239655-20902-3-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 24 Mar 2017 09:04:35 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1643 Lines: 48 On 03/24/17 at 08:57am, Ard Biesheuvel wrote: > On 23 March 2017 at 03:27, Baoquan He wrote: > > EFI allocate runtime services regions from EFI_VA_START, -4G, down > > to -64G, EFI_VA_END. > > OK, so is the size of the region 60 GB or 64 GB? This suggests 60 GB, > but the comment you update suggests 64 GB. Ah, sorry, here it should be -68G. The reserved EFI region is [-68G, -4G), amount is 64G. Thanks, will repost with updated log. > > > The mechanism was introduced in > > commit d2f7cbe7b26a7 ("x86/efi: Runtime services virtual mapping"). > > > > Clean it up to avoid confusion. > > > > Signed-off-by: Baoquan He > > Cc: Matt Fleming > > Cc: Ard Biesheuvel > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: "H. Peter Anvin" > > Cc: Borislav Petkov > > Cc: x86@kernel.org > > Cc: linux-efi@vger.kernel.org > > --- > > arch/x86/platform/efi/efi_64.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c > > index a4695da..6cbf9e0 100644 > > --- a/arch/x86/platform/efi/efi_64.c > > +++ b/arch/x86/platform/efi/efi_64.c > > @@ -47,7 +47,7 @@ > > #include > > > > /* > > - * We allocate runtime services regions bottom-up, starting from -4G, i.e. > > + * We allocate runtime services regions top-down, starting from -4G, i.e. > > * 0xffff_ffff_0000_0000 and limit EFI VA mapping space to 64G. > > */ > > static u64 efi_va = EFI_VA_START; > > -- > > 2.5.5 > >