Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753648AbdCXJaX (ORCPT ); Fri, 24 Mar 2017 05:30:23 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:16169 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbdCXJaO (ORCPT ); Fri, 24 Mar 2017 05:30:14 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 24 Mar 2017 02:27:14 -0700 Subject: Re: [PATCH] i2c: tegra-bpmp: Enable Tegra BPMP I2C adapter To: Thierry Reding References: <1489580410-9541-1-git-send-email-jonathanh@nvidia.com> <20170320140503.GA28203@ulmo.ba.sec> CC: Wolfram Sang , , , From: Jon Hunter Message-ID: <245d5500-5a99-cb76-f72d-16e2ebf3d415@nvidia.com> Date: Fri, 24 Mar 2017 09:30:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170320140503.GA28203@ulmo.ba.sec> X-Originating-IP: [10.21.132.151] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1331 Lines: 38 On 20/03/17 14:05, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Wed, Mar 15, 2017 at 12:20:10PM +0000, Jon Hunter wrote: >> Enable the Tegra BPMP I2C adapter by default if the Tegra BPMP itself >> is enabled. This adapter is used as the I2C interface for the PMIC on >> the Tegra186 Jetson-TX2 platform. >> >> Signed-off-by: Jon Hunter >> --- >> drivers/i2c/busses/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig >> index 8adc0f1d7ad0..9e024ae8a067 100644 >> --- a/drivers/i2c/busses/Kconfig >> +++ b/drivers/i2c/busses/Kconfig >> @@ -933,6 +933,7 @@ config I2C_TEGRA >> config I2C_TEGRA_BPMP >> tristate "NVIDIA Tegra BPMP I2C controller" >> depends on TEGRA_BPMP >> + default y if TEGRA_BPMP > > I think "if TEGRA_BPMP" in the line above implies "depends on > TEGRA_BPMP", so it's redundant. "default y" should be equivalent. That > said, I'm not sure if we really want to always enable this. There could > be boards with a BPMP that don't use the I2C controller. Initially, I had thought about putting a select for this under the ARCH_TEGRA_186_SOC in drivers/soc/tegra/Kconfig. We could always do that in the future if it turns out the BPMP does not have i2c on newer chips. Cheers Jon -- nvpublic