Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754289AbdCXKOK (ORCPT ); Fri, 24 Mar 2017 06:14:10 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:35642 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbdCXKOE (ORCPT ); Fri, 24 Mar 2017 06:14:04 -0400 MIME-Version: 1.0 In-Reply-To: <20170324084341.GA10793@kroah.com> References: <20170323131737.GA13629@kroah.com> <20170324083711.7920-1-pranjas@gmail.com> <20170324084341.GA10793@kroah.com> From: Pranay Srivastava Date: Fri, 24 Mar 2017 15:44:02 +0530 Message-ID: Subject: Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as per required context To: Greg KH Cc: William Hubbs , Christopher Brannon , kirk@reisers.ca, Samuel Thibault , Stephen Rothwell , speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 660 Lines: 26 On Fri, Mar 24, 2017 at 2:13 PM, Greg KH wrote: > On Fri, Mar 24, 2017 at 02:07:11PM +0530, Pranay Kr. Srivastava wrote: >> speakup_allocate used GFP_ATOMIC for allocations >> even while during initialization due to it's use >> in notifier call. > > Is that a problem? No that's the way it should be. I was just trying to say that allocation should be context based[?]. If we can be lenient then that's better[?] > >> Pass GFP_ flags as well to speakup_allocate depending >> on the context it is called in. > > At init, we should be fine to use GFP_ATOMIC, so is this change really > needed? > > thanks, > > greg k-h -- ---P.K.S