Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934473AbdCXNKb (ORCPT <rfc822;w@1wt.eu>);
        Fri, 24 Mar 2017 09:10:31 -0400
Received: from mail.kernel.org ([198.145.29.136]:41914 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754267AbdCXNKM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 24 Mar 2017 09:10:12 -0400
Date: Fri, 24 Mar 2017 21:09:36 +0800
From: Shawn Guo <shawnguo@kernel.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Jagan Teki <jagan@openedev.com>, linux-arm-kernel@lists.infradead.org,
        devicetree@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Matteo Lisi <matteo.lisi@engicam.com>,
        Michael Trimarchi <michael@amarulasolutions.com>
Subject: Re: [PATCH 07/12] ARM: dts: imx6ul-isiot: Add Sound card with codec
 node
Message-ID: <20170324130934.GO30608@dragon>
References: <1490204897-14525-1-git-send-email-jagan@openedev.com>
 <1490204897-14525-8-git-send-email-jagan@openedev.com>
 <20170324052324.GF30608@dragon>
 <CAMty3ZBSVgL==LsCzsODkL117WFL4Pv4kwhXhxc3wDWre3i-zA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMty3ZBSVgL==LsCzsODkL117WFL4Pv4kwhXhxc3wDWre3i-zA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1417
Lines: 36

On Fri, Mar 24, 2017 at 02:02:38PM +0530, Jagan Teki wrote:
> On Fri, Mar 24, 2017 at 10:53 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Wed, Mar 22, 2017 at 11:18:12PM +0530, Jagan Teki wrote:
> >> From: Jagan Teki <jagan@amarulasolutions.com>
> >>
> >> Add support for Sound card and related codec(via i2c1) nodes
> >> on Engicam Is.IoT MX6UL variant module boards.
> >>
> >> Cc: Shawn Guo <shawnguo@kernel.org>
> >> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> >> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> >> ---
> >>  arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 11 +++++++++++
> >>  arch/arm/boot/dts/imx6ul-isiot.dtsi        | 30 ++++++++++++++++++++++++++++++
> >>  2 files changed, 41 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> index b149b5e..c79fa42 100644
> >> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> >> @@ -41,6 +41,17 @@
> >>   */
> >>
> >>  &i2c1 {
> >> +     codec: sgtl5000@0a {
> >
> >         sgtl5000: codec@a {
> 
> Just to understand, why codec: sgtl5000@0a not a suitable notation?
> couldn't see any Documentation.

The node name should be generic.  Please see ePAPR '2.2.2 Generic Names
Recommendation'.  Also, the unit-address shouldn't have leading zeros.

Shawn