Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965563AbdCXOYs (ORCPT ); Fri, 24 Mar 2017 10:24:48 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:33272 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936242AbdCXOYa (ORCPT ); Fri, 24 Mar 2017 10:24:30 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=fb.com; Subject: Re: [PATCH] block: floppy: use setup_timer To: Geliang Tang , Jiri Kosina , "Mike Christie" , Hannes Reinecke , Dan Williams References: <4841d2c2936addc27a2e774041d04ec16885ba03.1490341208.git.geliangtang@gmail.com> <458035c91812e9de996605012e897ff85b9fffb8.1490341514.git.geliangtang@gmail.com> CC: From: Jens Axboe Message-ID: <723dbb89-3d30-f62f-bdfe-ef07f85a6adb@fb.com> Date: Fri, 24 Mar 2017 08:23:15 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <458035c91812e9de996605012e897ff85b9fffb8.1490341514.git.geliangtang@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: BN6PR06CA0011.namprd06.prod.outlook.com (10.175.123.149) To BN6PR15MB1188.namprd15.prod.outlook.com (10.172.205.142) X-MS-Office365-Filtering-Correlation-Id: e055564d-0142-432f-a131-08d472c1525a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR15MB1188; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1188;3:nD5PeALa8Y2cffyURwfFTXTe3nJeBkGYc7IFvkSS6gEK36nNF2UJGAU3zVBe7acaGMJnCPIPzHbP3eFzmWueJ2zzQl1+LkxEAqqXV693UJGZtrsOYe9M1MYFGaeDTypB2PSaEbOEkZ7qmgzHw77LzAd8ONxoUsf6GykdzVdDlTGiruFWCktivgwTpRZmNFwwlkfxJywNs9VJi4wOFFF09WQUmFZ7/52D8H4WmoFkdYSXA464SSen28hDCzaPG6NaW0UZVDxeiXv132v1H4HufA==;25:W60Suz70dguWsCpPCxPi3FyjPSVyKt3kAur0THK4e8jy8teNsEjSE1o4i6zMvogVluFEqQnM/C5lPvuKlapaE1B2td0kpaDhb/MpZCe4HxNfAb+tH0H53G1Pn69cbDpNYC4GWVD//QIbWVAEZfGQ5W/30S10iumOzm00l7zabhh/so9VGfwUL/yEmKknH2ctvblm1yvo4QaLpnFqZ8iORfc0LXynw5juIO5zP5rzFhZ3ujU5AESX1Dct8ZSTg/x2kBEDoxaIJRjFoYp6sv40R1WOc02L15RGzmcuINs/fwy5kRVwu17t5Gl++ukOeb+6ipSFBVvrGySpzJxhdzeg9iOy73fG41W/Cm7F0HTwX+Uq+DF8fevw65Q2iXWergXUhSNHeevh87iubRP/4hYIs/s5p3Gq8Nkcr4id2GBL53vnplpnZcNe9CcAd3XS8a/SDTht93LmTY/kIpxvZmm1fQ== X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1188;31:d0Pm90F7sqp4Tfl3cSWuK8raSY2CiQPzlZhpnCmEpA6+iTha8HyR8BwxoEAsRFOWEu+p1+NB2JYHdM6jOS/wLlYK/RTdJji/yADmcqzItxZ+GRHygzCmo1bYy+xM3xDvXOcC0e9dENLmgBSx2KTAnYUgEhZdakRqSXOreLJmoknG9bhJ2tJ+rYy0mIN/WhPbjFVIJ6h0vFnVANZ98za99xFzvuhekuFPizNTXuzXv+JS4XjRvuMmlkXH//zwx/mKNaopnr4QfvYYP34oDXAWg8c6x1wcYordKFoNVt6jNX0=;20:iriWV48uGcwCjJAzji/Krr5loiPW/x0YQXIEIzN5zF9oG5r+V7dEQQHU4+qUpNuneb8wj2qBZIOoo39EO8FcZvwjqjoFnWWQIcXWifSWRFW9B9NEJ73uLRfz8ZxsdbzvfRvt+5emgiYaPhkwcctAYGSkrxkxD6Lk+tOPZAztwsadez6ic/SDo0eoNf4KrTU+ANQkHgB75niaKzbo4zFUoSOtkYuDtVFykgsD5hF2AqU5wN7qD/rZ7CpidgNtONR71f3vGcASM2MOz9XEADX/6oqgKHxKhVTcxqTVgc/AOnF1dqR7Kzl9jn6Ykh/w/PXLDi2Ltfv5Vn10E1OdD4dT1clbdTMeeWZEC5VhDSLnwoEaro2bGnJ1iLf8nN10NmB6fUwvPO650k3MUe+QTDl64ZrSVJaM13PuW6zuLsoFjFgelaTSPwscsFKgf3BRAPy6pqCvEB85Vajw337Oq3vmKKUi2LoLRT8TD6YoRf2csjzQGcGr4e/Mw0bWKtIFgoi5 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(20161123558025)(6072148);SRVR:BN6PR15MB1188;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1188; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1188;4:uP/E2iKhOfakaaIS3/uyDwCXcza2NH4NcUCwfSLp4RLKZfFrlMN8lVPadvV/OoBdhL0r+csqdgPea4uATFahBvo8K1DbqrUxu/zvXdkmgjTGWUbr2OSV8QZBzlZnKvHuonKrmB6WHIMlAJRLWYS2eztSZBbzQZuOSJEpMQ3pHmBXP6Nbj3cJgkFWAnPr4vBce6+n2yLKAx7rOdiVYB48UCiVqMRsKJFbUCyg6UwvPmScYE/cEVq5H4sg+A3M0HyErFQ0MDFKHsf2vo0Qa2I69Wa8bkvl2AyPOwblobNkjbwRO4hNFP0o/xvZupjJUOxKKlg3NpC3yZ/yrE3IGgjwKTojdMsLN+x46SFEhS5RxAWpqerjpgpg8e9lg0LYW1d3snae/ASfqJzIGycMY5dvjwAN8/CqnRXP4FlyfrxUYjJxGgxQU/g3tVr7G+NCm1uQZgvbVzDMgNqmK5GzS4G+uE/ouQrXMncIWVeF7895vYTPrQ23jyN3AzdD8z+xk5PtXNxyLn4rXZ8Rwu4R0mOegyCZftM19hOsCk80JMnf9rVGSV7MhZvLM3dXEXShwc+88yEtYgPk/I91GbtpcpFnUC1/IfJqN7pCBais8DybfYM= X-Forefront-PRVS: 0256C18696 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39410400002)(39830400002)(39450400003)(24454002)(377454003)(31686004)(50986999)(31696002)(117156001)(54356999)(81166006)(50466002)(2950100002)(83506001)(90366009)(76176999)(558084003)(25786009)(6116002)(6486002)(42186005)(4001350100001)(230700001)(3846002)(8676002)(5660300001)(77096006)(229853002)(86362001)(65806001)(65956001)(65826007)(33646002)(66066001)(23746002)(64126003)(2906002)(6246003)(305945005)(7736002)(189998001)(53936002)(36756003)(38730400002)(6666003)(47776003)(4326008);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1188;H:[192.168.1.154];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1188;23:sDwhwPDeb28fYQEg8jZkGS2+cOf+8n7AMeNdM?= =?Windows-1252?Q?u+OkzVPLiekSI30iD4JKOt2xxswy3TMEVI1kBgErZvxqdLpbUw/OyhS1?= =?Windows-1252?Q?2o+myzIKKEbqSs4R6BlCA04ydCj6TfwH5P4YpXSl4U2wf32ZYIUAGHJs?= =?Windows-1252?Q?2rzIoQvksTGJjYB243bTD/75/M9Edhu+bTCLLN8Y06WVd6VoDEXNtRTV?= =?Windows-1252?Q?2aG9LhqoKiego9NmnLAe5g7S+YmgLEWjWsW3F8C9wMPjSsnSe+4IN8ff?= =?Windows-1252?Q?nuk2yvyH8UKYQmQTuq8bBafWCjEVdzz05CTFpqdRbtV8+o/B7LZp5qCH?= =?Windows-1252?Q?lGl5AdresUpmORUo44rKbzom2cMytteMAv4ACZmYUk+PyvNo31CNNKJV?= =?Windows-1252?Q?fmdvcZ83c2r2DwRYZ8HxmIKSltLBq4Oc+0nlrycQFzt/kDDaULg6VCOD?= =?Windows-1252?Q?wE24IIrBlZe6GwtlHBG8UceRIJs6qGMIU8ZCgrQbIz0NWA0+9Th43Hl7?= =?Windows-1252?Q?HOJ8JGazi5NsC/Kb6eOWkQaujXSknIMU1uwLOquMN4IMA620lZIMg9hY?= =?Windows-1252?Q?iwQM9NJcRJrjHer954ya59DFCSU4ur6PTHgz6QB8Gwq0zjKowWSqh2xB?= =?Windows-1252?Q?d9Hex/Ptr0pKRmPl2H27LyUTP2g8nGFDgLJXLYv0cE4+YIRHJJzKj0qe?= =?Windows-1252?Q?qSXoH/sUgR7SYBbnamN7i6PV6ZdLBCTqgK5MZHBiC7UfKYREin0DB/W/?= =?Windows-1252?Q?3oh5103LUp3auWrnit31uiPCPopvVpUYuRx3IhNR8HszAtZwC8AC4Tmw?= =?Windows-1252?Q?L1F7Px+yQikRKwbNF6aQg9mX7GIZmszwe6F9nez545Iob4uH113yYLF0?= =?Windows-1252?Q?1mN1SVQqq9kFjAty58/YKgXNdqzWZLC3sX5eoh7wJqVWGZGQxGAm52kp?= =?Windows-1252?Q?2vVWcSQAFAY5UdDDJnHji1AY68I2snRHVXmcZF93QB9yyUt8Hqwodef6?= =?Windows-1252?Q?WYq4EhSM8ZDrD8FmLv6segkdHWscSphf3dbzvoo9VCSIAZD8CkICdjBR?= =?Windows-1252?Q?HCeWKI7x48cvpgDpcLFD/wAmNczYpAWv3DlADgBEFApQhSnRDhkuxSrk?= =?Windows-1252?Q?D13CtxI6UVkky/hbCBPCpfijZr3jta0boydrubWjY2zL6yZRUOYb/zcZ?= =?Windows-1252?Q?ZCTDEIjxfW79K2CoIc9sPPTUAyyclwZXjMMBmOMyopGiZMO0ELmwXGNe?= =?Windows-1252?Q?FxFv8rTC8Os59IVWE6G3t6jmwLkD+xI7beJyuNP3ebZ+llk3Tn+ZlTAL?= =?Windows-1252?Q?9G6IPF6JF+RGP2ngboXoV5Vng=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1188;6:kGRqbXgSKbeu/MOax9Y0rmyldxaTCaWs0Pq486XetTqAXp19tfT6QS0y/64jxIKXcOcfS5DQHkdynz0HYgmtCaNmRftnasV3QreCMvrhdWm4uGygsAQW4IVZZwzQw/Sko0vR4Mzzo3eJY0kc/z0uuy7zT+kToAJv4qnALvqGeJVvE+ByeR96FeyGOyGwBrJ2Ppip2Q/vGN3Vxa4YV7rZ3739vCK2utgNzq9FN13jgyCIJGLTw9RT4Yz3g1rXMxx6UjCYwo5y9+7GURoXimW/8Hp6L5EPDLkkWlIRRa7lwCUqK7dMGzUbXzZ6Lt8iJmj2EvIofSURD5IvYibd13n7kYtkN8EzguizBl6NDiGhOfXDIEn8ceBcRJFvJBsFAaJMx4GQ7red40YT2bF7m2BBrQ==;5:gRWwliIGffe9+lgP3BdKz9yvxIMphzhuqHopywtJVITHdWWn7gffR4pvpXsUDghzphLP4MByQPnEz492/ZdAkvrVxspi5arvExtCBVfki4nTYzoIgyDLXKp8kgEvRqjsQPjeqouiBxRdBhfq4W+sBg==;24:G12NaIyryT2rAuQGMaA3159JT1t2Fedzhq/bH2dNdOp9nEWec5Zc+EOSJUy5de6V9nF71YagNYxENIcAfmr1pWtRgr7AqDUAeAq3X0w1SUQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1188;7:wHuTCijDwToBy+lL39yw1URas6iGoygtqqRb5j1uHzCeOeFBWu0N60pGS7M7SEMPM8hNzCFU7QfIVgSG+uXLQj/c8Q6j5gqwwbDrhX4XW+7Aq45ORsuVpTtX0SczP1y04MBkuKOB3nXREfcuBIRLja7AB4tUNTlHn85DDTsZtVVuGo2fFPHaG1qmZ7DhEhra80rs050/u+pbtsoORmzyRiBxFndPJRyNgB0G/MHOSYGG0RfPj9dy5uM8hcvYM8qUCl9RD3wafcY4GvlwNbMRBHbA6UD+bHA9fORFHDHgF3ZCeEWT2hYjJSNPe7ZHOJlo+oP/M/1rGvrU4hZaydcaYg==;20:YzClajFXcE2XSWARqCQQ5wETx8kxW9JLsVEGcmLUZ/tE2HN2ZFUoylzt95bcOdfXatMN7aYtC/DfAQF7TETehtZglHYQgx4CxZ0I1/VJBNj9YTBiyfklcWKeZT73bZZlV188hMMBApmgLusk9javS+7Rntc9h7opDXQWOUzXpy0= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2017 14:23:19.4962 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1188 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-24_13:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 242 Lines: 8 On 03/24/2017 08:15 AM, Geliang Tang wrote: > Use setup_timer() instead of init_timer() to simplify the code. Added this (and mg_disk) for 4.12. Please consider using a cover letter sending more than one patch in the future. -- Jens Axboe