Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966041AbdCXOuY (ORCPT ); Fri, 24 Mar 2017 10:50:24 -0400 Received: from lb2-smtp-cloud2.xs4all.net ([194.109.24.25]:41300 "EHLO lb2-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965934AbdCXOtl (ORCPT ); Fri, 24 Mar 2017 10:49:41 -0400 Subject: Re: [PATCH v7 9/9] media: venus: enable building of Venus video driver To: Stanimir Varbanov , Mauro Carvalho Chehab References: <1489423058-12492-1-git-send-email-stanimir.varbanov@linaro.org> <1489423058-12492-10-git-send-email-stanimir.varbanov@linaro.org> Cc: Andy Gross , Bjorn Andersson , Stephen Boyd , Srinivas Kandagatla , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org From: Hans Verkuil Message-ID: Date: Fri, 24 Mar 2017 15:49:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1489423058-12492-10-git-send-email-stanimir.varbanov@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2648 Lines: 73 On 03/13/17 17:37, Stanimir Varbanov wrote: > This adds Venus driver Makefile and changes v4l2 platform > Makefile/Kconfig in order to enable building of the driver. > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platform/Kconfig | 14 ++++++++++++++ > drivers/media/platform/Makefile | 2 ++ > drivers/media/platform/qcom/venus/Makefile | 11 +++++++++++ > 3 files changed, 27 insertions(+) > create mode 100644 drivers/media/platform/qcom/venus/Makefile > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index 53f6f12bff0d..8a6c3d664307 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -447,6 +447,20 @@ config VIDEO_TI_VPE_DEBUG > ---help--- > Enable debug messages on VPE driver. > > +config VIDEO_QCOM_VENUS > + tristate "Qualcomm Venus V4L2 encoder/decoder driver" > + depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA Can this also depend on COMPILE_TEST? And if so, please make sure it compile on both a 32 and 64 bit environment to shake out any compiler warnings. Regards, Hans > + depends on ARCH_QCOM && OF > + depends on IOMMU_DMA > + select QCOM_MDT_LOADER > + select VIDEOBUF2_DMA_SG > + select V4L2_MEM2MEM_DEV > + ---help--- > + This is a V4L2 driver for Qualcomm Venus video accelerator > + hardware. It accelerates encoding and decoding operations > + on various Qualcomm SoCs. > + To compile this driver as a module choose m here. > + > endif # V4L_MEM2MEM_DRIVERS > > # TI VIDEO PORT Helper Modules > diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile > index 8959f6e6692a..bd5cae68db8a 100644 > --- a/drivers/media/platform/Makefile > +++ b/drivers/media/platform/Makefile > @@ -73,3 +73,5 @@ obj-$(CONFIG_VIDEO_MEDIATEK_VCODEC) += mtk-vcodec/ > obj-$(CONFIG_VIDEO_MEDIATEK_MDP) += mtk-mdp/ > > obj-$(CONFIG_VIDEO_MEDIATEK_JPEG) += mtk-jpeg/ > + > +obj-$(CONFIG_VIDEO_QCOM_VENUS) += qcom/venus/ > diff --git a/drivers/media/platform/qcom/venus/Makefile b/drivers/media/platform/qcom/venus/Makefile > new file mode 100644 > index 000000000000..0fe9afb83697 > --- /dev/null > +++ b/drivers/media/platform/qcom/venus/Makefile > @@ -0,0 +1,11 @@ > +# Makefile for Qualcomm Venus driver > + > +venus-core-objs += core.o helpers.o firmware.o \ > + hfi_venus.o hfi_msgs.o hfi_cmds.o hfi.o > + > +venus-dec-objs += vdec.o vdec_ctrls.o > +venus-enc-objs += venc.o venc_ctrls.o > + > +obj-$(CONFIG_VIDEO_QCOM_VENUS) += venus-core.o > +obj-$(CONFIG_VIDEO_QCOM_VENUS) += venus-dec.o > +obj-$(CONFIG_VIDEO_QCOM_VENUS) += venus-enc.o >