Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757464AbdCXPbA (ORCPT ); Fri, 24 Mar 2017 11:31:00 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37656 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935200AbdCXPaw (ORCPT ); Fri, 24 Mar 2017 11:30:52 -0400 Subject: Re: [PATCH v7 9/9] media: venus: enable building of Venus video driver To: Hans Verkuil , Mauro Carvalho Chehab References: <1489423058-12492-1-git-send-email-stanimir.varbanov@linaro.org> <1489423058-12492-10-git-send-email-stanimir.varbanov@linaro.org> Cc: Andy Gross , Bjorn Andersson , Stephen Boyd , Srinivas Kandagatla , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org From: Stanimir Varbanov Message-ID: Date: Fri, 24 Mar 2017 17:30:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1310 Lines: 36 Thanks for the comments! On 03/24/2017 04:49 PM, Hans Verkuil wrote: > On 03/13/17 17:37, Stanimir Varbanov wrote: >> This adds Venus driver Makefile and changes v4l2 platform >> Makefile/Kconfig in order to enable building of the driver. >> >> Signed-off-by: Stanimir Varbanov >> --- >> drivers/media/platform/Kconfig | 14 ++++++++++++++ >> drivers/media/platform/Makefile | 2 ++ >> drivers/media/platform/qcom/venus/Makefile | 11 +++++++++++ >> 3 files changed, 27 insertions(+) >> create mode 100644 drivers/media/platform/qcom/venus/Makefile >> >> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig >> index 53f6f12bff0d..8a6c3d664307 100644 >> --- a/drivers/media/platform/Kconfig >> +++ b/drivers/media/platform/Kconfig >> @@ -447,6 +447,20 @@ config VIDEO_TI_VPE_DEBUG >> ---help--- >> Enable debug messages on VPE driver. >> >> +config VIDEO_QCOM_VENUS >> + tristate "Qualcomm Venus V4L2 encoder/decoder driver" >> + depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA > > Can this also depend on COMPILE_TEST? And if so, please make sure it compile on both > a 32 and 64 bit environment to shake out any compiler warnings. > yes I can add COMPILE_TEST, at least on -next it should be fine. -- regards, Stan