Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936347AbdCXPcx (ORCPT ); Fri, 24 Mar 2017 11:32:53 -0400 Received: from mail-lf0-f52.google.com ([209.85.215.52]:33519 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936115AbdCXPcv (ORCPT ); Fri, 24 Mar 2017 11:32:51 -0400 Subject: Re: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node To: Jacopo Mondi , geert+renesas@glider.be, laurent.pinchart@ideasonboard.com, chris.brandt@renesas.com, linus.walleij@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk References: <1490368934-12494-1-git-send-email-jacopo+renesas@jmondi.org> <1490368934-12494-5-git-send-email-jacopo+renesas@jmondi.org> Cc: linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Fri, 24 Mar 2017 18:32:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490368934-12494-5-git-send-email-jacopo+renesas@jmondi.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 731 Lines: 28 Hello! On 03/24/2017 06:22 PM, Jacopo Mondi wrote: > Add pin controller node with 12 gpio controller sub-nodes to > r7s72100 dtsi. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > --- > arch/arm/boot/dts/r7s72100.dtsi | 80 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 80 insertions(+) > > diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi > index b8aa256..83e8f27 100644 > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi > @@ -180,6 +180,86 @@ > }; > }; > > + pinctrl: pinctrl@fcfe3000 { I suggest to call it "pin-controller@...", no need to reduce. [...] MBR, Sergei