Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933871AbdCXQDT (ORCPT ); Fri, 24 Mar 2017 12:03:19 -0400 Received: from mga09.intel.com ([134.134.136.24]:55027 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753051AbdCXQCs (ORCPT ); Fri, 24 Mar 2017 12:02:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,215,1486454400"; d="scan'208";a="1146547309" Date: Fri, 24 Mar 2017 18:01:57 +0200 From: Mika Westerberg To: Andy Shevchenko Cc: Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, Dmitry Torokhov , Hans de Goede , linux-kernel@vger.kernel.org, Jarkko Nikula , linux-acpi@vger.kernel.org Subject: Re: [PATCH v1 0/8] gpio: acpi: Make it working Message-ID: <20170324160157.GF2957@lahna.fi.intel.com> References: <20170323194618.26548-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170323194618.26548-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1883 Lines: 42 On Thu, Mar 23, 2017 at 09:46:10PM +0200, Andy Shevchenko wrote: > Currently GPIO ACPI library provides an API to get a GPIO resources > (IO or interrupt) from ACPI tables for the individual drivers. > > This library has few flaws which makes some devices not working: > - the library allows to abuse ACPI by using a _CRS fallback mechanism > - the library neglects flags of the resource > > In this series: > - the _CRS fallback is forbidden > - the pin configuration follows what firmware wants to > - the documentation is updated in order to clarify corner cases > > After this series it's possible to use GPIO pins for input (interrupt) > which were configured as output by BIOS by some reason. It's a crucial > functionality for IoT open connected boards where user may choose any of > available pin for almost any of available function, including GPIO input > (interrupt). > > Current bad behaviour was first reported by Jarkko Nikula few months ago. > > Andy Shevchenko (8): > gpiolib: Export gpiod_configure_flags() to internal users > gpio: acpi: Align acpi_find_gpio() with DT version > gpio: acpi: Do sanity check for GpioInt in acpi_find_gpio() > gpio: acpi: Even more tighten up ACPI GPIO lookups > gpio: acpi: Synchronize acpi_find_gpio() and acpi_gpio_count() > gpio: acpi: Explain how to get GPIO descriptors in ACPI case > gpio: acpi: Factor out acpi_gpio_to_gpiod_flags() helper > gpio: acpi: Override GPIO initialization flags > > Documentation/acpi/gpio-properties.txt | 60 ++++++++++++ > drivers/gpio/gpiolib-acpi.c | 162 +++++++++++++++++++-------------- > drivers/gpio/gpiolib.c | 10 +- > drivers/gpio/gpiolib.h | 17 +++- > 4 files changed, 176 insertions(+), 73 deletions(-) Really nice work! For the whole series, Reviewed-by: Mika Westerberg