Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936435AbdCXQwe (ORCPT ); Fri, 24 Mar 2017 12:52:34 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:36014 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936112AbdCXQwW (ORCPT ); Fri, 24 Mar 2017 12:52:22 -0400 Subject: Re: [RFT PATCH 5/6] pinctrl: meson: use gpio-ranges from DT To: Martin Blumenstingl References: <1490286449-19448-1-git-send-email-narmstrong@baylibre.com> <1490286449-19448-6-git-send-email-narmstrong@baylibre.com> Cc: khilman@baylibre.com, carlo@caione.org, linus.walleij@linaro.org, linux-amlogic@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Neil Armstrong Organization: Baylibre Message-ID: <45f14809-8303-b58b-1f38-7b76a3b7c00b@baylibre.com> Date: Fri, 24 Mar 2017 17:52:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 592 Lines: 20 On 03/23/2017 09:09 PM, Martin Blumenstingl wrote: > Hi Neil, > > On Thu, Mar 23, 2017 at 5:27 PM, Neil Armstrong wrote: >> When trying to add a gpio-hog, we enter a weird loop where the gpio-ranges >> is needed when gpiochip_add_data() is called but in the current implementation >> the ranges are added from the driver afterwards. >> >> A simple solution is to rely on the DR gpio-ranges attribute and remove the >> call to gpiochip_add_pin_range(). > did you mean devicetree or DT instead of "DR"? > > > Regards, > Martin > Indeed, sorry for the typo. Neil