Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965744AbdCXSnE (ORCPT ); Fri, 24 Mar 2017 14:43:04 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:36028 "EHLO mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965619AbdCXSm4 (ORCPT ); Fri, 24 Mar 2017 14:42:56 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Ard Biesheuvel Date: Fri, 24 Mar 2017 18:42:49 +0000 Message-ID: Subject: Re: [PATCH v2 4/7] efi/capsule: Adjust return type of efi_capsule_setup_info To: Jan Kiszka Cc: Matt Fleming , "linux-efi@vger.kernel.org" , Linux Kernel Mailing List , Andy Shevchenko , "Bryan O'Donoghue" , Hock Leong Kweh , Borislav Petkov , Sascha Weisenberger Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 30 On 24 March 2017 at 17:34, Jan Kiszka wrote: > We actually expect int at the caller and never return any size > information. > > Signed-off-by: Jan Kiszka Reviewed-by: Ard Biesheuvel > --- > drivers/firmware/efi/capsule-loader.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/efi/capsule-loader.c b/drivers/firmware/efi/capsule-loader.c > index 3fb91e1..37d3f6e 100644 > --- a/drivers/firmware/efi/capsule-loader.c > +++ b/drivers/firmware/efi/capsule-loader.c > @@ -53,8 +53,8 @@ static void efi_free_all_buff_pages(struct capsule_info *cap_info) > * @kbuff: a mapped first page buffer pointer > * @hdr_bytes: the total received number of bytes for efi header > **/ > -static ssize_t efi_capsule_setup_info(struct capsule_info *cap_info, > - void *kbuff, size_t hdr_bytes) > +static int efi_capsule_setup_info(struct capsule_info *cap_info, > + void *kbuff, size_t hdr_bytes) > { > efi_capsule_header_t *cap_hdr; > size_t pages_needed; > -- > 2.10.2 >