Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936062AbdCXTa2 (ORCPT ); Fri, 24 Mar 2017 15:30:28 -0400 Received: from mail-by2nam01on0089.outbound.protection.outlook.com ([104.47.34.89]:22859 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966966AbdCXT34 (ORCPT ); Fri, 24 Mar 2017 15:29:56 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; From: Wendy Liang To: CC: , , "Wendy Liang" , Wendy Liang , Michal Simek Subject: [RFC LINUX PATCH 09/19] remoteproc: check firmware checksum in rproc_is_running_fw() Date: Fri, 24 Mar 2017 12:22:25 -0700 Message-ID: <1490383355-23176-10-git-send-email-jliang@xilinx.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1490383355-23176-1-git-send-email-jliang@xilinx.com> References: <1490383355-23176-1-git-send-email-jliang@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-22962.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(39450400003)(39410400002)(39840400002)(39850400002)(2980300002)(438002)(189002)(199003)(9170700003)(106466001)(189998001)(38730400002)(77096006)(110136004)(50986999)(107886003)(36386004)(33646002)(47776003)(2351001)(48376002)(5660300001)(36756003)(76176999)(50466002)(305945005)(356003)(81166006)(9786002)(4326008)(54906002)(5003940100001)(2950100002)(50226002)(6916009)(8936002)(8676002)(2906002)(6666003)(107986001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR02MB1390;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT030;1:CYKSahDqpip/dp7VzjU9XUGcVFsSGmXZqasbTykbvq7JPkGMhXO/qZkbJ+PEWKIfUbHmeXVD4oG3K39GG1sbkIx+IlL7aR2IUrIti2k88Avdotlo3QkOMgjhpAxr3IX/J5qxtzSUsysdM1rTuKOeqZ0q7UyTE2EpPw1WgTHJcVuaL2uyaJcYyUH75KOIAJb9NDaf45ekK//aAz2O5eLAjbpaYlxYBuJdPhZAb1TqQn5IoEQ6CUuVt3PfXNhF4LyR/bfBOp6eIFfzEbaG2dHNfkAYCBR/apoCqdwD8V8hvQwwkqe5NgiTl08Pvpmi7QWiEMVjqNdibJBvGncldz/WAqg8ArtIVxB/KIwFtWdclU0TRCuPvlol3ZqDyuvbu4WmAeWPnS8CEtzX7PEjGuDw8BpPulvMklqlkSh4MmlYL2R+RPmijT6rhzihrdcbiA/LEASpmT2WYBNfNQJGec0AU7Rg61xnzRNwX7Z/JE2egejyFbofHl6Qsm3a+mLftDoAyojw2HSi9Ep0u71utCl/rTtqV/DSsS9s3ziE6MRZAjFYNLZdoWevNbLD6xCczHDC59nnHrMiFZDGjj3gYF1aDQ== MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 66de6e3e-9a26-4980-2bbd-08d472ec22eb X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002)(2017030254075);SRVR:SN1PR02MB1390; X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1390;3:125SxEXbTqGnJvB4ONOlVLhEEkRwIzLAJ7KMCvg+It5vy5eWU+MSZHoT0j6jWJhX8JlO/I7gJJHzVBRXxWf6wE03yL+weWlrul+k278h5rTb8BLkWeSoz6e0sFGryZzmz6wYC9/ZkQzuU7ADd/FDdhHyUC9hRnZzGiUNqw6IQZJyoQ6D2JLGVaDfiZ6t2NV6/E3/yOpVtjQCXmXMcjIvOSI8V0udpWfJqll/x626YyS0TtldiGSNdoDhaOMuigGweiC6/iyuRX+YUI1gPGQbBWl57UNT8e5u0dLN/0vGYr4kOlsZKg6oNpJNHMDdXKCA4bRpBa0VGcsM71NsH6o7H+IM32W2Pof4R4PmcshM+5EItjlRSN0NHBmjfKU9dbvLkPZ5isW3/cc+az2bID3aGtArpONtE7QzeAF/FVqDdsg=;25:b1PXrvyC2icSYGzwLcllHVH/oYUxWjTej0QmRaio+McT+K5oyp6HVhx+MVnQAv0rtdBq2Rczgp96Nb9PNVrpkLX1SwSdYmWJRWEErheLfQ108IVfp7vy1rav1oFYjD5riv1jQ1J4goO+4D3lW5vi2Qh0qCNUbzoPc4W+O1OMzxxmNmUyO+82YVGQmlqsjuQRxCh/aRs9jBjOlcoH1KDnxMMnR8b+rLFBljt6qe/rQWMM8Hx61ZFfsqj+XX40+IyfwMiaF0wP268Id+oLbSjwUcztIqVzfQVZNlULXSUDEiX37Z5wagLKq2oa2+VLbjRLbvgy+FVJO6NjOEBbbYDIXK7Bmzi4O/vE3AJwRuoVssQYyPGo1Xr71K8i8tTaBxQOrcTdKaGpEKPA8KJ2Mx7BuSxdFH8ADpMc4U46bl8F1EI49mfl49dOe3ySbXD4HVqXkreeNcsSdtJmAUlcDuIFiQ== X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1390;31:F7DxxoyQl22FMwMOwE1ymHQjaV4XFz9n4Z2Bml+NCahPVM8Jk4X/jUTRVzHZ5+jfKDkdOftv/k1GiXbXaPNrcO8At57KbGQ2x4sqU40sraXFHsjoYtZ4B6m5YjB0UiDkjF77asj3i2btyAURxqpT1XKNiAQghvmdt8towS8uGcZG3LlYC/TQa95RK/rMq/f8ZLPU77tZDnODZ3tNGjVBnNmhOFAqiPLEqRDvDzB3p7BwfvppV0QRcrxOlsYdJb9Zh9uhmPq6i/yy+FLzoIEOX3xKaBacstwr6Xin17LRjDs=;20:dslZB7VAJNajdOxjFj/WR+FQ+v2okn8xKytIfe5O54d+uwCQw7hE8ul359JJFSHVeYT2d7q4RHV4/o+B4+hE7rbn3KroqgMGAZLdzLKtdGttGkn6hYPxPamLft6EgJ3UMGmXJmTHG0aXEiKl6uBtqUFJAokvdsauDPx8nygDrmUJfQU97y+nR7OhAN8G6rYF2NlGVErnKsxVFLBYRdqpVnXy1MIctXd35Ii5AYTIhDJWAF6Cv5c7cxQ6L2Nxseh3heCSVwH/NnevnV9gWm9avcg1SKUAhBpTz1VSyfc8pN6jJcapH7TNokNH7QPuaS/CGbpj/eEAK39RJE0owEqABC7AC6a4fJNYq/IvrK2pcZLKADiYla+QDiVls1MbV5AikzmbjOU2pKRlSUA0+kJ13Vlofh5R60UHnNkgmjRCp2Fy0nqkrOH/uj4UQH8QivXQsFX+L2JGP0o6JOsEBPlMacvIP3t6AZriSU8sbxr5s9Arcnj9x8DCN9luvSswr+0c X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13017025)(5005006)(13015025)(13024025)(8121501046)(13023025)(13018025)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123558025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:SN1PR02MB1390;BCL:0;PCL:0;RULEID:;SRVR:SN1PR02MB1390; X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1390;4:1nUkfQK3GcUYQQZyygN0s4ZYkSuaOdHSN7EO8pvyw2Gt0VwF+4HtyP2xR2ep6Ajk+ox+5K42H9kEx61KAhdVlPrw2P9arJgeoWERS4u+9XhjWrBDdrDw/duLNnXr86BFfFVSjhBZiXTczqZ9UgR423g2vIfPB/Xtw1uTW2v3IkTVBaJAdinn7ftA/Z6hRRclloVGXUcDjmJaz/d2AqmnMEFsLaI44KVTu7FaOo8FOmeyROTZMZ9tS4WaMrmt15lfZN5ELdDjLlgy+ovVEHMVboTTHylj98Hzmc+U5WuC8s2elG4SL+GcSaCHoWZxSwlnU3pePQN7x9F9SY4jSUWvVvdDrybLQOPX2TW/F1ivqXosba/KNwuGjVmt24F7ijfoj6YbnBeowneHDQCWTvy7x0kZqnKGyLjmwnuddY6RedUqobP87JzximTyp/JNeAOzMGopEJhVysKuF81VpPUH1I2aj4Qy+aOZJ4wD1fcUVkkS0WSd2JpL3cVGWyqYo1m9uHqLJMcoOmtR2C3DVRblhBr+lMSevvBtBF3hncxrCIUsQ05G/9wLLO7P+1Dm8NOGS+vqtRYSKxxbQ1fZETlQIM6G6+QZbGOZqG70pUY13OwafyZPn0JqF9kDauXvI15Xjfx+8QHf38Ms3VZuFPUw6+Mhfb1teI/qNGYyOnp+XWOFoO7MPJTdsvSlqr/1D4OyAWAIiYr7B7cl8vDMZV2fvbAKtboC71zaSlti/O0ckncQxx7vcViXxeBT0JiLg3OqsXOgksoJsro1Wmz2doeF9Q== X-Forefront-PRVS: 0256C18696 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR02MB1390;23:EwobI+9kPTZ2Ij14rWJHM2VA/C4xqAnGf/+8Q1EeU?= =?us-ascii?Q?dxGLAKBtkY1Cw1wFEeAL2tmIV8ezFBMANVvJM5ZtF8854bwtTQTr9AKHeHP5?= =?us-ascii?Q?e5ugvZDXRzxyU+/lDQHNFJhXcPybQGdak47I7vM0v7BZxH8KsrGmoxpUWpFk?= =?us-ascii?Q?CQ4QsrECebl4WKWu1fxSBUeoN6EResnwsxLgpMpRR69f0PRb1vJfTA497VAm?= =?us-ascii?Q?Iz3W8Q2phx+sKq52BsLRvIz61rRXB7JXjrBYmZAeZur5gh3SWwYMwJfK+zuj?= =?us-ascii?Q?Id405F577CbHsnUQUq5QdPo10bJO4RvenARP7keRmr2KZaBzkBoee8IY5Pyg?= =?us-ascii?Q?0Wg10raCMFEv4jZKwiVsLiww+EoS8P7UsfyDdmidIy0vBy8bS93sb8YWJU7u?= =?us-ascii?Q?4HuRRxbvoSGhuDWWh4ALDXP8l9WBd/JngQ7XVD9/5mUZbPyzH35EWdX0Rs4i?= =?us-ascii?Q?xfda7GGZTnfWQm+18QRb4cmIep13136rynpoXdLWIh7kT1uwhsKLlRJtVshq?= =?us-ascii?Q?TT08vwzb1kfT44Yo2nfKX2vCJ29IHJhS5emLS5QDk6+W0x7pecaY78Y12Cpj?= =?us-ascii?Q?OHNqbdM0PT3TdMoOLaDHfJNO0jHWLwvf4kw7VKmhkHYyO9vxwQjVT+Y/Ty6l?= =?us-ascii?Q?b9GcxHT/84Q6G8Oh3WJfcSB1FU8w55a5bwT5JERxxdEChM7fROxB637KWv9S?= =?us-ascii?Q?Ch0bLnTYaDQSQDwvRq/5TlFG70laXhcpS9EoS8GbyWwEopbR0RTJ9GUlX2Dn?= =?us-ascii?Q?gfDZ9snSr82/YYSjABwSpzrOjw2TmJSD8/pF692m9rAbKydMzKmi7bo0VkPq?= =?us-ascii?Q?pkVmCsM9+5inKmVPJjKdEq2KGmg5Hm3Clp/BbQj/9PxDgEv397afygOuQcNu?= =?us-ascii?Q?+LXfGjJKUgz4P02sXldIz1wYIFOZZtfsTcxXsxWS4zWu20LN6VYuDxyQdXVl?= =?us-ascii?Q?0LtdYsq/Cfpm/trJtnx7bRwLtbeASlWdMsjpVV2pR8eJRQ4YerGqybuDG3pJ?= =?us-ascii?Q?LGpGjcg6W0rsxzROnj0Ojo1aY1TaX2+p1qMvDzQZrV8vcbsYffuEFKvvtT/7?= =?us-ascii?Q?PEI/vyte7Uak2uldELzkxLjIYtJ?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1390;6:yX+odNEcDNFD0JzTEX6ejWppLeSrqbCVgci40xnsp0AP1rY5plqHFkMHWcp0s0qca+Mrq7XqrGb1wbEfW/VnOiZ0n/JB3bNiUJzEodYOzsxYYu0Jdtx/NXsA51fNGxnkPLWr/KvE/CG+J8Ema4Eg/iqFtyROwYNEKA5ttyBMv9wSwZcdighXGhhN16ldIbslAPKJ0V1NPCSvTAmwnhgoXD1hlNEQFdwTZfxeDdtViJCAFsG6bH+wIMzvCAijOzoeKxcwutM4PdlN/qifq7i1RhNswAW6W3tWAufuMUrUf6I55bmLoOLmqXTc4b81TTBwrhcScOrRjtvZxAW1gnxp0tMFbYqcwdI0v1+T79sua38oYNEr9trje4pMPw0HL9mbklk9SCULTf1uSA8JB3F6732NRppnrYn6IiAGcEYQzLc=;5:K8LvAXiaGFe8XDnx2mfAOM/GMAiXsrEwEqgpYFb+vG1I5m5gBdynHV+tLs6lzh3zTrb+G7S/s8BKk97kY2F5JXxZ8JkjYenDegyD3l3xAmABd06ufoGRkJCtwLs96BLsh87lP54fCvZX8UY5+tf7ZQ==;24:Zzz3P2nc79BdbIPZNi/ObfTAUr3G82YtRR4+cWK21tPzljwjVbE/YZrJFLWc8lRpdjG5zvzfE2Xkkb2UDznySi5zJY9/+PnWF1byjFnb9Ck= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1390;7:AmnKTMuDG5N+tzWXX+xaTQHTh6dBV8oJjT98iItu1SXqfMwY5I1ocwlQxAt7LOsLIYUINm+sWA7cr8KJQX8tDQjuZEMPWRDgZ78opqHfL4XyVcgIv9cHR9bDtEHCWg3Zg7r7Hcr0dRhIbga6RJh6L7wVZbUh+t86nQyJNJYNPfhpiBxroAz0Zxy0ONg9/1pLKjQaXcLtFowfWHDzj+KEE9m0HHIkDIHnyc3VtbbECwpiJ7J2AmJNPRIQmR76+i98+E0Vez1pvLv44oWRTY25KKHmVSg4EEN+1W7A7c9tiNrhlhy6AIvGb8kIBCaOpj6cL74q4wH9PrIbqfrFoQS1dA== X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2017 19:29:48.7268 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB1390 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1740 Lines: 59 From: Wendy Liang In rproc_is_running_fw() function, set the firmware checksum in resource in the resource table and compared it with the one in the loaded resource table. If the firmware checksum in the loaded resource table matches the one calculated with the firmware, the remote is running with the expected firmware. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek --- drivers/remoteproc/remoteproc_core.c | 29 ++++++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 447c28b..e4fb289 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -956,10 +956,33 @@ struct fw_rsc_fw_chksum *rproc_handle_fw_chksum(struct rproc *rproc, */ static bool rproc_is_running_fw(struct rproc *rproc, const struct firmware *fw) { - (void)rproc; - (void) fw; + struct resource_table *loaded_table; + struct fw_rsc_fw_chksum *rsc, *loaded_rsc; + int rsc_fw_chksum_offset; - return false; + rsc = rproc_handle_fw_chksum(rproc, fw, &rsc_fw_chksum_offset); + if (!rsc) + return false; + + if (!rproc_is_running(rproc)) + return false; + + /* look for the loaded resource table */ + loaded_table = rproc_find_loaded_rsc_table(rproc, fw); + if (!loaded_table) + return false; + + loaded_rsc = (void *)loaded_table + rsc_fw_chksum_offset; + if (!loaded_rsc->algo || !loaded_rsc->chksum) + return false; + + if (strncmp(rsc->algo, loaded_rsc->algo, strlen(rsc->algo))) + return false; + + if (memcmp(rsc->chksum, loaded_rsc->chksum, sizeof(rsc->chksum))) + return false; + + return true; } /* -- 1.9.1