Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936191AbdCXVYt (ORCPT ); Fri, 24 Mar 2017 17:24:49 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:36678 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756441AbdCXVYl (ORCPT ); Fri, 24 Mar 2017 17:24:41 -0400 MIME-Version: 1.0 In-Reply-To: <20170324103940.30902-1-tobias.regnery@gmail.com> References: <20170324103940.30902-1-tobias.regnery@gmail.com> From: Arnd Bergmann Date: Fri, 24 Mar 2017 22:23:48 +0100 X-Google-Sender-Auth: 5K5yQFd67p6JAgcLg6J3yxt4rIg Message-ID: Subject: Re: [PATCH] of: add stub for of_n_addr_cells To: Tobias Regnery Cc: Rob Herring , devicetree@vger.kernel.org, Linux Kernel Mailing List , Simon Horman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 39 On Fri, Mar 24, 2017 at 11:39 AM, Tobias Regnery wrote: > With CONFIG_OF=n and CONFIG_COMPILE_TEST=y the rcar pci-e driver fails to > build on arm: > > drivers/pci/host/pcie-rcar.c: In function 'pci_dma_range_parser_init': > drivers/pci/host/pcie-rcar.c:1035:16: error: implicit declaration of function 'of_n_addr_cells' [-Werror=implicit-function-declaration] > parser->pna = of_n_addr_cells(node); > ^~~~~~~~~~~~~~~ > > Fix this by adding an inline stub for of_n_addr_cells > > Signed-off-by: Tobias Regnery > --- > This is against next-20140324 > > include/linux/of.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/of.h b/include/linux/of.h > index 21e6323de0f3..9978c918222e 100644 > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -710,6 +710,11 @@ static inline struct device_node *of_get_cpu_node(int cpu, > return NULL; > } > > +static inline int of_n_addr_cells(struct device_node *np) > +{ > + return 0; > +} > + This looks good, but we should also do the same thing for of_n_size_cells(). I think I sent something like this a few years ago, but never resubmitted it when it was ignored at first. Arnd