DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C504461B93
Date: Fri, 24 Mar 2017 17:42:35 -0700
From: Jessica Yu <jeyu@redhat.com>
To: Kees Cook <keescook@chromium.org>
Cc: Eddie Kovsky <ewk@edkovsky.org>, Rusty Russell <rusty@rustcorp.com.au>,
        LKML <linux-kernel@vger.kernel.org>,
        "kernel-hardening@lists.openwall.com" 
        <kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH v3 1/2] module: verify address is read-only
Message-ID: <20170325004235.rzpwhvh6h2eapllj@jeyu>
References: <20170323025549.19588-1-ewk@edkovsky.org>
 <20170323025549.19588-2-ewk@edkovsky.org>
 <CAGXu5j+iwUYhU13D0pWA_LHdBX9z48fO4aK-9sSdJ=TZaMSsrQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <CAGXu5j+iwUYhU13D0pWA_LHdBX9z48fO4aK-9sSdJ=TZaMSsrQ@mail.gmail.com>
User-Agent: NeoMutt/20161126 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 871
Lines: 25

+++ Kees Cook [23/03/17 14:13 -0700]:
>On Wed, Mar 22, 2017 at 7:55 PM, Eddie Kovsky <ewk@edkovsky.org> wrote:
>> Implement a mechanism to check if a module's address is in
>> the rodata or ro_after_init sections. It mimics the exsiting functions
>> that test if an address is inside a module's text section.
>>
>> Functions that take a module as an argument will be able to
>> verify that the module is in a read-only section.
>>
>> Signed-off-by: Eddie Kovsky <ewk@edkovsky.org>
>
>Awesome! I'll be glad to have these.
>
>Reviewed-by: Kees Cook <keescook@chromium.org>
>
>Jessica, if this looks good to you, should this go via modules or via
>my tree? If mine, can I have your Ack?

Sure, would be happy to let you take this patch through your tree. I
only had a few minor comments left, so I think just one more small
respin and it'll be good to go.

Thanks!

Jessica