Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937003AbdCYB7v (ORCPT ); Fri, 24 Mar 2017 21:59:51 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:36029 "EHLO mail-it0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932447AbdCYB7m (ORCPT ); Fri, 24 Mar 2017 21:59:42 -0400 MIME-Version: 1.0 In-Reply-To: <20170325004235.rzpwhvh6h2eapllj@jeyu> References: <20170323025549.19588-1-ewk@edkovsky.org> <20170323025549.19588-2-ewk@edkovsky.org> <20170325004235.rzpwhvh6h2eapllj@jeyu> From: Kees Cook Date: Fri, 24 Mar 2017 18:59:40 -0700 X-Google-Sender-Auth: xsANcVxGVBFzCEwoZsul_mJQO5E Message-ID: Subject: Re: [PATCH v3 1/2] module: verify address is read-only To: Jessica Yu Cc: Eddie Kovsky , Rusty Russell , LKML , "kernel-hardening@lists.openwall.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1102 Lines: 36 On Fri, Mar 24, 2017 at 5:42 PM, Jessica Yu wrote: > +++ Kees Cook [23/03/17 14:13 -0700]: >> >> On Wed, Mar 22, 2017 at 7:55 PM, Eddie Kovsky wrote: >>> >>> Implement a mechanism to check if a module's address is in >>> the rodata or ro_after_init sections. It mimics the exsiting functions >>> that test if an address is inside a module's text section. >>> >>> Functions that take a module as an argument will be able to >>> verify that the module is in a read-only section. >>> >>> Signed-off-by: Eddie Kovsky >> >> >> Awesome! I'll be glad to have these. >> >> Reviewed-by: Kees Cook >> >> Jessica, if this looks good to you, should this go via modules or via >> my tree? If mine, can I have your Ack? > > > Sure, would be happy to let you take this patch through your tree. I > only had a few minor comments left, so I think just one more small > respin and it'll be good to go. Awesome, I'll wait for v4 and your Ack and put it through the kspp tree. :) Thanks for the review! -Kees -- Kees Cook Pixel Security