Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965893AbdCYC4s (ORCPT ); Fri, 24 Mar 2017 22:56:48 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:34600 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965008AbdCYC4l (ORCPT ); Fri, 24 Mar 2017 22:56:41 -0400 Reply-To: minyard@acm.org Subject: Re: [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF References: <1490284420-26657-1-git-send-email-okaya@codeaurora.org> To: Sinan Kaya , linux-acpi@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Rafael J. Wysocki" , Len Brown , linux-kernel@vger.kernel.org From: Corey Minyard Message-ID: <78897278-9240-6794-e99b-f3ff3013304f@acm.org> Date: Fri, 24 Mar 2017 21:56:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1490284420-26657-1-git-send-email-okaya@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 35 Oops, yes, this is an issue. However, it should probably depend on IPMI_HANDLER, not the individual interface types. -corey On 03/23/2017 10:53 AM, Sinan Kaya wrote: > ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver > to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces. > > IPMI_SSIF is an alternative BMC communication method. It allows BMC to be > accessed over an I2C bus instead of a standard interface. > > Enabling ACPI_IPMI over IPMI_SSIF with this change. > > Signed-off-by: Sinan Kaya > --- > drivers/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index 83e5f7e..8767062 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -256,7 +256,7 @@ config ACPI_PROCESSOR > > config ACPI_IPMI > tristate "IPMI" > - depends on IPMI_SI > + depends on IPMI_SI||IPMI_SSIF > default n > help > This driver enables the ACPI to access the BMC controller. And it