Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937142AbdCYC74 (ORCPT ); Fri, 24 Mar 2017 22:59:56 -0400 Received: from mail-ot0-f196.google.com ([74.125.82.196]:36373 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934104AbdCYC7s (ORCPT ); Fri, 24 Mar 2017 22:59:48 -0400 Reply-To: minyard@acm.org Subject: Re: [PATCH] ipmi_ssif: use setup_timer References: <4841d2c2936addc27a2e774041d04ec16885ba03.1490341208.git.geliangtang@gmail.com> To: Geliang Tang Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org From: Corey Minyard Message-ID: <8c8dfe9f-331a-92b2-9889-6b2a4f862bdc@acm.org> Date: Fri, 24 Mar 2017 21:59:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 31 A little nicer, yes. In queue for the next release. Thanks, -corey On 03/24/2017 09:15 AM, Geliang Tang wrote: > Use setup_timer() instead of init_timer() to simplify the code. > > Signed-off-by: Geliang Tang > --- > drivers/char/ipmi/ipmi_ssif.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index cca6e5b..a92a049 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1642,9 +1642,8 @@ static int ssif_probe(struct i2c_client *client, const struct i2c_device_id *id) > > spin_lock_init(&ssif_info->lock); > ssif_info->ssif_state = SSIF_NORMAL; > - init_timer(&ssif_info->retry_timer); > - ssif_info->retry_timer.data = (unsigned long) ssif_info; > - ssif_info->retry_timer.function = retry_timeout; > + setup_timer(&ssif_info->retry_timer, retry_timeout, > + (unsigned long)ssif_info); > > for (i = 0; i < SSIF_NUM_STATS; i++) > atomic_set(&ssif_info->stats[i], 0);