Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937197AbdCYHSt (ORCPT ); Sat, 25 Mar 2017 03:18:49 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36197 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S936987AbdCYHSk (ORCPT ); Sat, 25 Mar 2017 03:18:40 -0400 Subject: Re: [PATCH v5 2/5] perf report: Find the inline stack for a given address To: Jin Yao , acme@kernel.org References: <1489700547-7260-1-git-send-email-yao.jin@linux.intel.com> <1489700547-7260-3-git-send-email-yao.jin@linux.intel.com> Cc: jolsa@kernel.org, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, milian.wolff@kdab.com, yao.jin@intel.com, Ravi Bangoria From: Ravi Bangoria Date: Sat, 25 Mar 2017 12:48:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1489700547-7260-3-git-send-email-yao.jin@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 17032507-0024-0000-0000-0000161F5190 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006845; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000206; SDB=6.00838579; UDB=6.00412398; IPR=6.00616370; BA=6.00005235; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014804; XFM=3.00000013; UTC=2017-03-25 07:18:36 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17032507-0025-0000-0000-000049BACEF3 Message-Id: <58D619C1.50706@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-25_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703250067 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1362 Lines: 37 Hi Jin / Arnaldo, I see a build failure with this patch: On Friday 17 March 2017 03:12 AM, Jin Yao wrote: > It would be useful for perf to support a mode to query the > inline stack for a given callgraph address. This would simplify > finding the right code in code that does a lot of inlining. > > The srcline.c has contained the code which supports to translate > the address to filename:line_nr. This patch just extends the > function to let it support getting the inline stacks. ... > + while (getline(&filename, &len, fp) != -1) { > + if (filename_split(filename, &line_nr) != 1) { > + free(filename); > + goto out; > + } > + > + if (inline_list__append(filename, NULL, line_nr, node) != 0) util/srcline.c: In function ?addr2inlines?: util/srcline.c:403:7: error: too few arguments to function ?inline_list__append? if (inline_list__append(filename, NULL, line_nr, node) != 0) ^ util/srcline.c:34:12: note: declared here static int inline_list__append(char *filename, char *funcname, int line_nr, ^ util/srcline.c: At top level: util/srcline.c:60:13: error: ?inline_list__reverse? defined but not used [-Werror=unused-function] static void inline_list__reverse(struct inline_node *node) ^ cc1: all warnings being treated as errors mv: cannot stat ?util/.srcline.o.tmp?: No such file or directory Thanks, Ravi