Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423AbdCYHy2 (ORCPT ); Sat, 25 Mar 2017 03:54:28 -0400 Received: from mga01.intel.com ([192.55.52.88]:60884 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbdCYHy0 (ORCPT ); Sat, 25 Mar 2017 03:54:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,218,1486454400"; d="scan'208";a="80881577" From: Felipe Balbi To: Shuah Khan , gregkh@linuxfoundation.org, kgene@kernel.org, krzk@kernel.org, javier@osg.samsung.com Cc: Shuah Khan , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 2/7] usb: dwc3: dwc3-omap: fix dwc3_omap_probe() do put_sync when get_sync works In-Reply-To: References: Date: Sat, 25 Mar 2017 09:53:17 +0200 Message-ID: <87k27d23o2.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 438 Lines: 16 Hi, Shuah Khan writes: > dwc3_omap_probe() does pm_runtime_put_sync() in its err1 handling when > pm_runtime_get_sync() fails. Fix it to do put_sync only when get_sync > succeeds. > > Signed-off-by: Shuah Khan sorry, not taking any of these pointless patches. There's nothing wrong with the goto labels, there's nothing wrong with the error path in any of these drivers. -- balbi