Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751688AbdCYTcc (ORCPT ); Sat, 25 Mar 2017 15:32:32 -0400 Received: from gproxy3-pub.mail.unifiedlayer.com ([69.89.30.42]:44342 "HELO gproxy3-pub.mail.unifiedlayer.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751462AbdCYTcb (ORCPT ); Sat, 25 Mar 2017 15:32:31 -0400 X-Authority-Analysis: v=2.1 cv=H5NInYoi c=1 sm=1 tr=0 a=6lV6tj8ir7tGSl/9xQZNPA==:117 a=6lV6tj8ir7tGSl/9xQZNPA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=N659UExz7-8A:10 a=6Iz7jQTuP9IA:10 a=pGLkceISAAAA:8 a=8c3eEqj4kgFpnY4Cq_0A:9 a=pILNOxqGKmIA:10 a=6kGIvZw6iX1k4Y-7sg4_:22 Subject: Re: [PATCH] aoe: use setup_timer To: Geliang Tang References: <4841d2c2936addc27a2e774041d04ec16885ba03.1490341208.git.geliangtang@gmail.com> Cc: linux-kernel@vger.kernel.org From: Ed Cashin Message-ID: <786b1a47-ef74-4333-a1c3-f1c1dc4a1db9@acm.org> Date: Sat, 25 Mar 2017 15:32:08 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <4841d2c2936addc27a2e774041d04ec16885ba03.1490341208.git.geliangtang@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box320.bluehost.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - acm.org X-BWhitelist: no X-Source-IP: 98.192.50.100 X-Exim-ID: 1crrQ2-0005AV-2c X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([10.0.0.86]) [98.192.50.100]:49549 X-Source-Auth: ed@cashinworks.com X-Email-Count: 2 X-Source-Cap: Y2FzaGlud287Y2FzaGlud287Ym94MzIwLmJsdWVob3N0LmNvbQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 787 Lines: 30 On 03/24/2017 10:15 AM, Geliang Tang wrote: > Use setup_timer() instead of init_timer() to simplify the code. > > Signed-off-by: Geliang Tang > --- > drivers/block/aoe/aoemain.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/block/aoe/aoemain.c b/drivers/block/aoe/aoemain.c > index 4b987c2..20865d4 100644 > --- a/drivers/block/aoe/aoemain.c > +++ b/drivers/block/aoe/aoemain.c > @@ -28,10 +28,8 @@ discover_timer(ulong vp) > > switch (vp) { > case TINIT: > - init_timer(&t); > + setup_timer(&t, discover_timer, TRUN); > spin_lock_init(&lock); > - t.data = TRUN; > - t.function = discover_timer; > die = 0; > case TRUN: > spin_lock_irqsave(&lock, flags); > This change looks OK to me, thanks. -- Ed