Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751732AbdCYTqS (ORCPT ); Sat, 25 Mar 2017 15:46:18 -0400 Received: from www.osadl.org ([62.245.132.105]:56847 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdCYTqQ (ORCPT ); Sat, 25 Mar 2017 15:46:16 -0400 From: Nicholas Mc Guire To: "Paul E. McKenney" Cc: Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH 1/2] rcu: use bool value directly Date: Sat, 25 Mar 2017 20:46:01 +0100 Message-Id: <1490471162-21390-1-git-send-email-der.herr@hofr.at> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1086 Lines: 35 beenonline is declared bool so no need for an explicit comparison Signed-off-by: Nicholas Mc Guire --- Found by coccinelle: boolinit.cocci complained about ./kernel/rcu/tree.c:2986:14-29: WARNING: Comparison of bool to 0/1 If the comparison was intended for readability I guess it should be against "false" not 0 - but it seems common to just use bool values directly. Patch was compile-tested with: x86_64_defconfig (implies CONFIG_TREE_RCU=y) (with some sparse warnings) Patch is against 4.11-rc3 (localversion-next is next-20170324) kernel/rcu/tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 712ddce..ab9fbec 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -2983,7 +2983,7 @@ __rcu_process_callbacks(struct rcu_state *rsp) bool needwake; struct rcu_data *rdp = raw_cpu_ptr(rsp->rda); - WARN_ON_ONCE(rdp->beenonline == 0); + WARN_ON_ONCE(!rdp->beenonline); /* Update RCU state based on any recent quiescent states. */ rcu_check_quiescent_state(rsp, rdp); -- 2.1.4