Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751230AbdCYWXj (ORCPT ); Sat, 25 Mar 2017 18:23:39 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:36974 "EHLO mail-it0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbdCYWXi (ORCPT ); Sat, 25 Mar 2017 18:23:38 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Linus Torvalds Date: Sat, 25 Mar 2017 15:23:35 -0700 X-Google-Sender-Auth: yV-bpONG7MT_ToLT0Mq1IDBnzW8 Message-ID: Subject: Re: Audit fixes for v4.11 (#1) To: Paul Moore Cc: linux-audit@redhat.com, Linux Kernel Mailing List , Dmitry Vyukov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 25 On Fri, Mar 24, 2017 at 2:39 PM, Paul Moore wrote: > > This code has passed our testsuite without problem and it has held up > to my ad-hoc stress tests (arguably better than the existing code), > please consider pulling this as fix for the next v4.11-rcX tag. Ok, pulled. However, looking at the changes in the patch it becomes obvious that it is now completely bogus to inline the "audit_signal_info()" function. That silly inline in the header file now only generates bigger and slower code, since that inlined function now calls another function auditd_test_task() that is *not* inlined, so it ends up being a function call anyway. It would be much better to just unlinline audit_signal_info(), move it into kernel/audit.c, and let the compiler then inline the __audit_signal_info() helper function (or just fold it into that function manually as part of the move). The whole reason for that inlined part, and the uninlined __audit_signal_info() helper was that the code *used* to be able to avoid a function call entirely. That reason is now gone. Linus