Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751659AbdCZUgq (ORCPT ); Sun, 26 Mar 2017 16:36:46 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:48390 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506AbdCZUgl (ORCPT ); Sun, 26 Mar 2017 16:36:41 -0400 Date: Sun, 26 Mar 2017 14:36:28 -0600 From: Jason Gunthorpe To: Jerry Snitselaar Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Peter Huewe , Jarkko Sakkinen , Marcel Selhorst Subject: Re: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks Message-ID: <20170326203628.GA3113@obsidianresearch.com> References: <20170325200521.19224-1-jsnitsel@redhat.com> <20170325200521.19224-2-jsnitsel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170325200521.19224-2-jsnitsel@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 519 Lines: 14 On Sat, Mar 25, 2017 at 01:05:21PM -0700, Jerry Snitselaar wrote: > @@ -672,7 +658,7 @@ void tpm_tis_remove(struct tpm_chip *chip) > interrupt = 0; > > tpm_tis_write32(priv, reg, ~TPM_GLOBAL_INT_ENABLE & interrupt); > - release_locality(chip, priv->locality, 1); > + release_locality(chip, priv->locality); Why is this done during remove? The tpm core should now keep things so that there is not a requested locality except during command so execution we should not get here with a requested locality.. Jason