Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751826AbdC0EXf (ORCPT ); Mon, 27 Mar 2017 00:23:35 -0400 Received: from mail-vk0-f54.google.com ([209.85.213.54]:35509 "EHLO mail-vk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbdC0EXd (ORCPT ); Mon, 27 Mar 2017 00:23:33 -0400 MIME-Version: 1.0 In-Reply-To: <4479175.Jfq03yCxQW@tauon.atsec.com> References: <20170325162654.3827-1-krzk@kernel.org> <2736911.EcZSki4vB1@positron.chronox.de> <20170326180012.3eic4bt2p6h6u3nh@kozik-lap> <4479175.Jfq03yCxQW@tauon.atsec.com> From: PrasannaKumar Muralidharan Date: Mon, 27 Mar 2017 09:53:11 +0530 Message-ID: Subject: Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver To: =?UTF-8?Q?Stephan_M=C3=BCller?= Cc: Krzysztof Kozlowski , Kukjin Kim , Javier Martinez Canillas , Matt Mackall , Herbert Xu , "David S. Miller" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org, Bartlomiej Zolnierkiewicz , Arnd Bergmann , Olof Johansson Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 345 Lines: 10 > Oh my, if you are right with your first guess, this is a bad DRNG design. > > Just out of curiousity: what happens if a caller invokes the seed function > twice or more times (each time with the sufficient amount of bits)? What is > your guess here? Should the second seed use the random data generated by the device? Regards, PrasannaKumar