Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751757AbdC0Fxp (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Mar 2017 01:53:45 -0400
Received: from conssluserg-04.nifty.com ([210.131.2.83]:18576 "EHLO
        conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751213AbdC0Fxf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Mar 2017 01:53:35 -0400
X-Greylist: delayed 1524 seconds by postgrey-1.27 at vger.kernel.org; Mon, 27 Mar 2017 01:53:34 EDT
DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com v2R5rV41027174
X-Nifty-SrcIP: [209.85.161.179]
MIME-Version: 1.0
In-Reply-To: <1489496093-15315-8-git-send-email-nicolas.dichtel@6wind.com>
References: <CAK7LNARpx7f0eV5_AiPmNYT7MsRbGFOygJwjfAzX_7aCpuHwuw@mail.gmail.com>
 <1489496093-15315-1-git-send-email-nicolas.dichtel@6wind.com> <1489496093-15315-8-git-send-email-nicolas.dichtel@6wind.com>
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Mon, 27 Mar 2017 14:53:30 +0900
X-Gmail-Original-Message-ID: <CAK7LNATUdjuNVdOEhitsPrpeORFOR2ER3OYDf9Pxn1JP639FeQ@mail.gmail.com>
Message-ID: <CAK7LNATUdjuNVdOEhitsPrpeORFOR2ER3OYDf9Pxn1JP639FeQ@mail.gmail.com>
Subject: Re: [PATCH v10 07/11] btrfs_tree.h: fix include from userland
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Michal Marek <mmarek@suse.com>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arch@vger.kernel.org, David Airlie <airlied@linux.ie>,
        "David S. Miller" <davem@davemloft.net>,
        Russell King <linux@armlinux.org.uk>, bp@alien8.de, slash.tmp@free.fr,
        Daniel Vetter <daniel.vetter@ffwll.ch>, rmk+kernel@armlinux.org.uk,
        msalter@redhat.com, jengelh@inai.de, hch@infradead.org,
        Tobias Klauser <tklauser@distanz.ch>, mpe@ellerman.id.au,
        Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
        "Dmitry V. Levin" <ldv@altlinux.org>,
        Herbert Xu <herbert@gondor.apana.org.au>, linux-rdma@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2R5sanx005013
Content-Length: 1283
Lines: 43

Hi Nicolas,


2017-03-14 21:54 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>:
> This patch prepares the uapi export by fixing the following errors:
>
> .../linux/btrfs_tree.h:283:2: error: #error "UUID items require BTRFS_UUID_SIZE == 16!"
>  #error "UUID items require BTRFS_UUID_SIZE == 16!"
>
> .../linux/btrfs_tree.h:390:12: error: ‘BTRFS_UUID_SIZE’ undeclared here (not in a function)
>   __u8 uuid[BTRFS_UUID_SIZE];
>             ^
> .../linux/btrfs_tree.h:796:16: error: ‘BTRFS_DEV_STAT_VALUES_MAX’ undeclared here (not in a function)
>   __le64 values[BTRFS_DEV_STAT_VALUES_MAX];
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
>  include/uapi/linux/btrfs_tree.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/btrfs_tree.h b/include/uapi/linux/btrfs_tree.h
> index 6a261cb52d95..6a754ada59af 100644
> --- a/include/uapi/linux/btrfs_tree.h
> +++ b/include/uapi/linux/btrfs_tree.h
> @@ -2,6 +2,7 @@
>  #define _BTRFS_CTREE_H_
>
>  #include <linux/types.h>
> +#include <linux/btrfs.h>
>

Can you move <linux/types.h> below <linux/btrfs.h>
to sort the includes alphabetically?

This also applies to:

include/uapi/linux/qrtr.h in 06/11
include/uapi/linux/cryptouser.h  in 08/11


-- 
Best Regards
Masahiro Yamada