Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752004AbdC0GYP (ORCPT ); Mon, 27 Mar 2017 02:24:15 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:35148 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751407AbdC0GYG (ORCPT ); Mon, 27 Mar 2017 02:24:06 -0400 MIME-Version: 1.0 In-Reply-To: <20170324023657.2iyh22lr52rme5bu@rob-hp-laptop> References: <1489729898-774-1-git-send-email-chunyan.zhang@spreadtrum.com> <1489729898-774-4-git-send-email-chunyan.zhang@spreadtrum.com> <20170324023657.2iyh22lr52rme5bu@rob-hp-laptop> From: Chunyan Zhang Date: Mon, 27 Mar 2017 14:23:59 +0800 Message-ID: Subject: Re: [PATCH V4 3/4] dt-bindings: serial: add a new compatible string for SC9860 To: Rob Herring Cc: Chunyan Zhang , Mark Rutland , "gregkh@linuxfoundation.org" , Catalin Marinas , Will Deacon , Arnd Bergmann , Mathieu Poirier , =?UTF-8?B?T3Jzb24gWmhhaSAo57+f5LqsKQ==?= , Sudeep Holla , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1662 Lines: 56 Hi Rob, On 24 March 2017 at 10:36, Rob Herring wrote: > On Fri, Mar 17, 2017 at 01:51:37PM +0800, Chunyan Zhang wrote: >> SC9860 use the same serial device which SC9836 uses, so added a new >> compatible string to support SC9860 as well, also added an example >> of how to describe this serial device in DT. >> >> Signed-off-by: Chunyan Zhang >> --- >> Documentation/devicetree/bindings/serial/sprd-uart.txt | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt >> index 2aff0f2..1db5d6f 100644 >> --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt >> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt >> @@ -1,7 +1,19 @@ >> * Spreadtrum serial UART >> >> Required properties: >> -- compatible: must be "sprd,sc9836-uart" >> +- compatible: must be one of: >> + * "sprd,sc9836-uart" >> + * "sprd,sc9860-uart", "sprd,sc9836-uart" >> + >> - reg: offset and length of the register set for the device >> - interrupts: exactly one interrupt specifier >> - clocks: phandles to input clocks. >> + >> +Example: >> + uart0: serial@000000 { > > serial@0 > Addressed this. > With that, > > Acked-by: Rob Herring Thanks for your review, Chunyan > > >> + compatible = "sprd,sc9860-uart", >> + "sprd,sc9836-uart"; >> + reg = <0x000000 0x100>; >> + interrupts = ; >> + clocks = <&ext_26m>; >> + }; >> -- >> 2.7.4 >>