Date: Mon, 27 Mar 2017 08:51:02 +0100
From: Okash Khawaja <okash.khawaja@gmail.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: gregkh@linuxfoundation.org, w.d.hubbs@gmail.com,
        chris@the-brannons.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org,
        rvarsha016@gmail.com, arushisinghal19971997@gmail.com, shiva@exdev.nl,
        speakup@linux-speakup.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: speakup: fix warning for static declaration
Message-ID: <20170327075102.GA21373@sanghar>
References: <20170327063728.GA21236@embeddedgus>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170327063728.GA21236@embeddedgus>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1072
Lines: 32

Hi Gustavo,

On Mon, Mar 27, 2017 at 01:37:29AM -0500, Gustavo A. R. Silva wrote:
> Fix the following sparse warning:
> symbol 'spk_serial_out' was not declared. Should it be static?
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/staging/speakup/serialio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c
> index 5e31aca..3fab1c3 100644
> --- a/drivers/staging/speakup/serialio.c
> +++ b/drivers/staging/speakup/serialio.c
> @@ -243,7 +243,7 @@ unsigned char spk_serial_in_nowait(void)
>  }
>  EXPORT_SYMBOL_GPL(spk_serial_in_nowait);
>  
> -int spk_serial_out(struct spk_synth *in_synth, const char ch)
> +static int spk_serial_out(struct spk_synth *in_synth, const char ch)
>  {
>  	if (in_synth->alive && spk_wait_for_xmitr(in_synth)) {
>  		outb_p(ch, speakup_info.port_tts);
> -- 
> 2.5.0
> 

Thanks for this :) Could you also move the function higher in the same
file - above line 139 where all static functions are defined?

Okash