Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752095AbdC0H4k (ORCPT ); Mon, 27 Mar 2017 03:56:40 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:55585 "EHLO hera.aquilenet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbdC0H41 (ORCPT ); Mon, 27 Mar 2017 03:56:27 -0400 Date: Mon, 27 Mar 2017 09:55:57 +0200 From: Samuel Thibault To: "Gustavo A. R. Silva" Cc: gregkh@linuxfoundation.org, w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, okash.khawaja@gmail.com, rvarsha016@gmail.com, arushisinghal19971997@gmail.com, shiva@exdev.nl, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: speakup: fix warning for static declaration Message-ID: <20170327075557.cw6bkjimxkew4wcq@var.youpi.perso.aquilenet.fr> Mail-Followup-To: Samuel Thibault , "Gustavo A. R. Silva" , gregkh@linuxfoundation.org, w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, okash.khawaja@gmail.com, rvarsha016@gmail.com, arushisinghal19971997@gmail.com, shiva@exdev.nl, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20170327063728.GA21236@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170327063728.GA21236@embeddedgus> Organization: I am not organized User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1276 Lines: 39 Gustavo A. R. Silva, on lun. 27 mars 2017 01:37:29 -0500, wrote: > Fix the following sparse warning: > symbol 'spk_serial_out' was not declared. Should it be static? > > Signed-off-by: Gustavo A. R. Silva Yes, indeed. Reviewed-by: Samuel Thibault Thanks > --- > drivers/staging/speakup/serialio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c > index 5e31aca..3fab1c3 100644 > --- a/drivers/staging/speakup/serialio.c > +++ b/drivers/staging/speakup/serialio.c > @@ -243,7 +243,7 @@ unsigned char spk_serial_in_nowait(void) > } > EXPORT_SYMBOL_GPL(spk_serial_in_nowait); > > -int spk_serial_out(struct spk_synth *in_synth, const char ch) > +static int spk_serial_out(struct spk_synth *in_synth, const char ch) > { > if (in_synth->alive && spk_wait_for_xmitr(in_synth)) { > outb_p(ch, speakup_info.port_tts); > -- > 2.5.0 > -- Samuel Je suis maintenant possesseur d'un ordinateur portable Compaq Armada 1592DT avec port infra-rouge. Auriez-vous connaissance de programmes suceptibles d'utiliser ce port afin de servir de télécommande ? -+- JN in NPC : ben quoi, c'est pas à ça que ça sert ?