Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173AbdC0H7b (ORCPT ); Mon, 27 Mar 2017 03:59:31 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:55605 "EHLO hera.aquilenet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbdC0H7W (ORCPT ); Mon, 27 Mar 2017 03:59:22 -0400 Date: Mon, 27 Mar 2017 09:58:53 +0200 From: Samuel Thibault To: Okash Khawaja Cc: "Gustavo A. R. Silva" , gregkh@linuxfoundation.org, w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, rvarsha016@gmail.com, arushisinghal19971997@gmail.com, shiva@exdev.nl, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: speakup: fix warning for static declaration Message-ID: <20170327075853.tmldwny6ih2f4vno@var.youpi.perso.aquilenet.fr> Mail-Followup-To: Samuel Thibault , Okash Khawaja , "Gustavo A. R. Silva" , gregkh@linuxfoundation.org, w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, rvarsha016@gmail.com, arushisinghal19971997@gmail.com, shiva@exdev.nl, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20170327063728.GA21236@embeddedgus> <20170327075102.GA21373@sanghar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170327075102.GA21373@sanghar> Organization: I am not organized User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 426 Lines: 10 Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote: > Thanks for this :) Could you also move the function higher in the same > file - above line 139 where all static functions are defined? I'd say no need for this. spk_serial_in is just above. Moving functions just for the sake of static vs non-static does not make the code more readable to my eyes :) (and it makes tracking changes harder in git annotate) Samuel