Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752327AbdC0IAv (ORCPT ); Mon, 27 Mar 2017 04:00:51 -0400 Received: from webclient5.webclient5.de ([136.243.32.179]:45049 "EHLO webclient5.webclient5.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752246AbdC0IAc (ORCPT ); Mon, 27 Mar 2017 04:00:32 -0400 X-Greylist: delayed 526 seconds by postgrey-1.27 at vger.kernel.org; Mon, 27 Mar 2017 04:00:31 EDT Subject: Re: [PATCH 2/6] hpet: remove unused writeq/readq function definitions To: Corentin Labbe References: <20170325144321.14284-3-clabbe.montjoie@gmail.com> <201703270716.y4O8Gn8V%fengguang.wu@intel.com> <20170327074352.GA12523@Red> Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org From: Clemens Ladisch Message-ID: <4473d49a-5203-a916-fdb6-402abfde5275@ladisch.de> Date: Mon, 27 Mar 2017 09:51:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170327074352.GA12523@Red> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 550 Lines: 15 Corentin Labbe wrote: > On Mon, Mar 27, 2017 at 07:49:34AM +0800, kbuild test robot wrote: >> drivers//char/hpet.c: In function 'hpet_timer_set_irq': >>>> drivers//char/hpet.c:207:7: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration] > > Wrongly believed that x86 and x86_64 shared writeq/readq. > Sorry, I will drop this patch > > Since the writeq/readq redefined is present in lots of other file, perhaps adding it to i386 could be done. Just use instead. Regards, Clemens