Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752038AbdC0INS (ORCPT ); Mon, 27 Mar 2017 04:13:18 -0400 Received: from bny206.haproxy.com ([37.58.153.206]:41651 "EHLO smtp.exceliance.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608AbdC0INL (ORCPT ); Mon, 27 Mar 2017 04:13:11 -0400 Date: Mon, 27 Mar 2017 10:11:11 +0200 From: Willy TARREAU To: Geert Uytterhoeven Cc: Andy Shevchenko , Miguel Ojeda Sandonis , Arnd Bergmann , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Linus Walleij Subject: Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Message-ID: <20170327081111.GA28802@haproxy.com> References: <20170324140635.56565-1-andriy.shevchenko@linux.intel.com> <1490365775.21738.7.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 27 On Fri, Mar 24, 2017 at 04:19:43PM +0100, Geert Uytterhoeven wrote: > Hi Andy, > > On Fri, Mar 24, 2017 at 3:29 PM, Andy Shevchenko > wrote: > > On Fri, 2017-03-24 at 15:19 +0100, Geert Uytterhoeven wrote: > >> On Fri, Mar 24, 2017 at 3:06 PM, Andy Shevchenko > >> wrote: > >> > It looks like panel.c belongs to auxdisplay subsystem. > >> > > >> > Move it to drivers/auxdisplay folder. > >> > No functional changes intended. > >> > >> I didn't move it to drivers/auxdisplay/ because it not only provides > >> auxdisplay functionality, but also keypad functionality. > > > > Yes, I have noticed this. But keypad functionality is optional while > > panel is main one. I think you would agree on this. > > I don't care that much, though. Willy? Well, as long as it continues to work, I don't really care either. The only thing to keep in mind is that it can be difficult to split the driver in two since in some cases it's possible to use the same lines for keypad and lcd. Willy