Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751980AbdC0IRb (ORCPT ); Mon, 27 Mar 2017 04:17:31 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34107 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406AbdC0IRX (ORCPT ); Mon, 27 Mar 2017 04:17:23 -0400 Date: Mon, 27 Mar 2017 17:11:05 +0900 From: Sergey Senozhatsky To: Joonsoo Kim Cc: Minchan Kim , Andrew Morton , Sergey Senozhatsky , linux-kernel@vger.kernel.org, kernel-team@lge.com Subject: Re: [PATCH 4/4] zram: make deduplication feature optional Message-ID: <20170327081105.GA390@jagdpanzerIV.localdomain> References: <1489632398-31501-1-git-send-email-iamjoonsoo.kim@lge.com> <1489632398-31501-5-git-send-email-iamjoonsoo.kim@lge.com> <20170322000059.GB30149@bbox> <20170323030530.GC17486@js1304-P5Q-DELUXE> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170323030530.GC17486@js1304-P5Q-DELUXE> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 746 Lines: 19 On (03/23/17 12:05), Joonsoo Kim wrote: > On Wed, Mar 22, 2017 at 09:00:59AM +0900, Minchan Kim wrote: > > On Thu, Mar 16, 2017 at 11:46:38AM +0900, js1304@gmail.com wrote: > > > From: Joonsoo Kim > > > > > > Benefit of deduplication is dependent on the workload so it's not > > > preferable to always enable. Therefore, make it optional. > > > > Please make it to Kconfig, too. And write down the description to impress > > "help a lot for users who uses zram to build output directory" > > And the feature should be disabled as default. > > Okay. so I was thinking for a moment -- do we want to keep this functionality in zram or may be it belongs to allocator (zsmalloc)? what do you think? just a question. -ss