Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752154AbdC0Ige (ORCPT ); Mon, 27 Mar 2017 04:36:34 -0400 Received: from merlin.infradead.org ([205.233.59.134]:45824 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbdC0IgR (ORCPT ); Mon, 27 Mar 2017 04:36:17 -0400 Date: Mon, 27 Mar 2017 10:35:08 +0200 From: Peter Zijlstra To: Steven Rostedt Cc: luca abeni , linux-kernel@vger.kernel.org, Ingo Molnar , Juri Lelli , Claudio Scordino , Tommaso Cucinotta , Daniel Bristot de Oliveira , Joel Fernandes , Mathieu Poirier Subject: Re: [RFC v5 5/9] sched/deadline: do not reclaim the whole CPU bandwidth Message-ID: <20170327083508.yjirmwch5jjpforz@hirez.programming.kicks-ass.net> References: <1490327582-4376-1-git-send-email-luca.abeni@santannapisa.it> <1490327582-4376-6-git-send-email-luca.abeni@santannapisa.it> <20170324140015.fptmmtqynvjy723q@hirez.programming.kicks-ass.net> <20170324225827.402a4f20@nowhere> <20170324223831.5feb1cd9@grimm.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170324223831.5feb1cd9@grimm.local.home> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1023 Lines: 31 On Fri, Mar 24, 2017 at 10:38:31PM -0400, Steven Rostedt wrote: > > > > @@ -6716,6 +6716,12 @@ static void sched_dl_do_global(void) > > > > raw_spin_unlock_irqrestore(&dl_b->lock, flags); > > > > > > > > rcu_read_unlock_sched(); > > > > + if (dl_b->bw == -1) > > > > + cpu_rq(cpu)->dl.deadline_bw_inv = 1 << 8; > > > > + else > > > > + cpu_rq(cpu)->dl.deadline_bw_inv = > > > > + to_ratio(global_rt_runtime(), > > > > + global_rt_period()) >> > > > > 12; > > > > > > Coding style requires braces here (on both legs of the condition).. > I'm not sure it's completely documented anywhere. Two parts; 1) I prefer braces over any multi line block, irrespective if its a single statement or not. This is, afaik, not strictly documented in coding style. Rationale is that missing braces are bad, and the larger the single statement, the harder it is to be sure it is in fact a single statement. 2) If one leg needs braces, then both should get it. This is in fact part of CodingStyle.