Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752167AbdC0Ik0 (ORCPT ); Mon, 27 Mar 2017 04:40:26 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:33329 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752116AbdC0IkT (ORCPT ); Mon, 27 Mar 2017 04:40:19 -0400 Date: Mon, 27 Mar 2017 09:39:37 +0100 From: Okash Khawaja To: Samuel Thibault , "Gustavo A. R. Silva" , gregkh@linuxfoundation.org, w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, rvarsha016@gmail.com, arushisinghal19971997@gmail.com, shiva@exdev.nl, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: speakup: fix warning for static declaration Message-ID: <20170327083937.GA21938@sanghar> References: <20170327063728.GA21236@embeddedgus> <20170327075102.GA21373@sanghar> <20170327075853.tmldwny6ih2f4vno@var.youpi.perso.aquilenet.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170327075853.tmldwny6ih2f4vno@var.youpi.perso.aquilenet.fr> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 676 Lines: 15 On Mon, Mar 27, 2017 at 09:58:53AM +0200, Samuel Thibault wrote: > Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote: > > Thanks for this :) Could you also move the function higher in the same > > file - above line 139 where all static functions are defined? > > I'd say no need for this. spk_serial_in is just above. Moving functions > just for the sake of static vs non-static does not make the code more > readable to my eyes :) > (and it makes tracking changes harder in git annotate) > > Samuel Fair enough. When I marked it as static and moved it higher, I misinterpreted your comment as we neither want it static nor moved. You probably meant the latter :)