Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752174AbdC0IpD (ORCPT ); Mon, 27 Mar 2017 04:45:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47844 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730AbdC0Ioy (ORCPT ); Mon, 27 Mar 2017 04:44:54 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1913C7E9D9 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=drjones@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1913C7E9D9 Date: Mon, 27 Mar 2017 10:44:42 +0200 From: Andrew Jones To: Daniel Lezcano Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, peterz@infradead.org, nicolas.pitre@linaro.org, rafael@kernel.org, vincent.guittot@linaro.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, kernel@stlinux.com, linux-samsung-soc@vger.kernel.org, netdev@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Subject: Re: [PATCH V8 1/3] irq: Add flags to request_percpu_irq function Message-ID: <20170327084442.xdosrvdzh2pvn7xa@kamzik.brq.redhat.com> References: <1490290924-12958-1-git-send-email-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490290924-12958-1-git-send-email-daniel.lezcano@linaro.org> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 27 Mar 2017 08:44:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 679 Lines: 17 On Thu, Mar 23, 2017 at 06:42:01PM +0100, Daniel Lezcano wrote: > diff --git a/drivers/clocksource/timer-nps.c b/drivers/clocksource/timer-nps.c > index da1f798..dbdb622 100644 > --- a/drivers/clocksource/timer-nps.c > +++ b/drivers/clocksource/timer-nps.c > @@ -256,7 +256,7 @@ static int __init nps_setup_clockevent(struct device_node *node) > return ret; > > /* Needs apriori irq_set_percpu_devid() done in intc map function */ > - ret = request_percpu_irq(nps_timer0_irq, timer_irq_handler, > + ret = request_percpu_irq(nps_timer0_irq, timer_irq_handler, IRQF_TIMER, > "Timer0 (per-cpu-tick)", > &nps_clockevent_device); Wrong parameter order here. drew