Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752509AbdC0Iy3 (ORCPT ); Mon, 27 Mar 2017 04:54:29 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:35073 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752161AbdC0IyS (ORCPT ); Mon, 27 Mar 2017 04:54:18 -0400 Date: Mon, 27 Mar 2017 10:53:55 +0200 From: Corentin Labbe To: Clemens Ladisch Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] hpet: remove unused writeq/readq function definitions Message-ID: <20170327085355.GB12523@Red> References: <20170325144321.14284-3-clabbe.montjoie@gmail.com> <201703270716.y4O8Gn8V%fengguang.wu@intel.com> <20170327074352.GA12523@Red> <4473d49a-5203-a916-fdb6-402abfde5275@ladisch.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4473d49a-5203-a916-fdb6-402abfde5275@ladisch.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 686 Lines: 17 On Mon, Mar 27, 2017 at 09:51:23AM +0200, Clemens Ladisch wrote: > Corentin Labbe wrote: > > On Mon, Mar 27, 2017 at 07:49:34AM +0800, kbuild test robot wrote: > >> drivers//char/hpet.c: In function 'hpet_timer_set_irq': > >>>> drivers//char/hpet.c:207:7: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration] > > > > Wrongly believed that x86 and x86_64 shared writeq/readq. > > Sorry, I will drop this patch > > > > Since the writeq/readq redefined is present in lots of other file, perhaps adding it to i386 could be done. > > Just use instead. > Thanks, much easier than add writeq/readq to whole x86 Regards