Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752164AbdC0Jig (ORCPT ); Mon, 27 Mar 2017 05:38:36 -0400 Received: from mga02.intel.com ([134.134.136.20]:64199 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751908AbdC0Ji1 (ORCPT ); Mon, 27 Mar 2017 05:38:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,231,1486454400"; d="scan'208";a="79683327" Subject: Re: [alsa-devel] [PATCH] ASoC: intel: remove unused variable data and associated code To: Colin King , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org References: <20170322143644.29051-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Keyon Jie Message-ID: <58D8DE49.5030306@linux.intel.com> Date: Mon, 27 Mar 2017 17:41:29 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20170322143644.29051-1-colin.king@canonical.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1517 Lines: 52 On 2017年03月22日 22:36, Colin King wrote: > From: Colin Ian King > > The variable 'data' is assigned null and never re-assigned. There > is also a redundant check for data being non-null which is always > false, so remove this and the variable data and dma_addr as they > are not used once the dead code has been removed. > > Detected with CoverityScan, CID#1324015 ("'Constant' variable gaurds > dead code") > > Signed-off-by: Colin Ian King Thank you for fixing it. Acked-by: Jie Yang thanks, ~Keyon > --- > sound/soc/intel/haswell/sst-haswell-ipc.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c > index a3459d1682a6..d33bdaf92c57 100644 > --- a/sound/soc/intel/haswell/sst-haswell-ipc.c > +++ b/sound/soc/intel/haswell/sst-haswell-ipc.c > @@ -2000,10 +2000,8 @@ int sst_hsw_module_set_param(struct sst_hsw *hsw, > u32 param_size, char *param) > { > int ret; > - unsigned char *data = NULL; > u32 header = 0; > u32 payload_size = 0, transfer_parameter_size = 0; > - dma_addr_t dma_addr = 0; > struct sst_hsw_transfer_parameter *parameter; > struct device *dev = hsw->dev; > > @@ -2047,10 +2045,6 @@ int sst_hsw_module_set_param(struct sst_hsw *hsw, > > kfree(parameter); > > - if (data) > - dma_free_coherent(hsw->dsp->dma_dev, > - param_size, (void *)data, dma_addr); > - > return ret; > } > >