Subject: Re: [BK PATCHES] add ata scsi driver
From: James Bottomley <James.Bottomley@steeleye.com>
To: Jens Axboe <axboe@suse.de>
Cc: torvalds@transmeta.com, Linux Kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <20030527171605.GL845@suse.de>
References: <1053972773.2298.177.camel@mulgrave>
	<20030526181852.GL845@suse.de> <1053974830.1768.190.camel@mulgrave>
	<20030526190707.GM845@suse.de> <1053976644.2298.194.camel@mulgrave>
	<20030526193327.GN845@suse.de> <20030527123901.GJ845@suse.de>
	<1054045594.1769.24.camel@mulgrave>  <20030527171605.GL845@suse.de>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: 27 May 2003 14:09:05 -0400
Message-Id: <1054058946.1769.223.camel@mulgrave>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 914
Lines: 23

On Tue, 2003-05-27 at 13:16, Jens Axboe wrote:
> If you increase it again, the maps are resized. Is that a problem? Seems
> ok to me.

What I mean is that you allocate memory whenever the depth increases. 
Even if you have an array large enough to accommodate the increase
(because you don't release when you decrease the tag depth).

On further examination, there's also an invalid tag race:  If a device
is throttling, it might want to do a big decrease followed fairly
quickly by a small increase.  When it does the increase, you potentially
still have outstanding tags above the new depth, which will now run off
the end of your newly allocated tag array.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/