Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753070AbdC0NSj (ORCPT ); Mon, 27 Mar 2017 09:18:39 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:30410 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752991AbdC0NSb (ORCPT ); Mon, 27 Mar 2017 09:18:31 -0400 Date: Mon, 27 Mar 2017 08:17:01 -0500 From: Bin Liu To: Moreno Bartalucci CC: Lars Melin , "linux-omap@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Alessio Igor Bogani Subject: Re: [PATCH] usb-musb: keep VBUS on when device is disconnected Message-ID: <20170327131701.GA12674@uda0271908> Mail-Followup-To: Bin Liu , Moreno Bartalucci , Lars Melin , "linux-omap@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Alessio Igor Bogani References: <20170315140801.97230-1-moreno.bartalucci@tecnorama.it> <20170324185836.GC19814@uda0271908> <2d10809f-d482-ffa9-30b7-8785e94ab102@gmail.com> <00882633-3F61-4010-A4D2-D04473282B10@tecnorama.it> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <00882633-3F61-4010-A4D2-D04473282B10@tecnorama.it> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1634 Lines: 46 On Mon, Mar 27, 2017 at 02:53:27PM +0200, Moreno Bartalucci wrote: > > Il giorno 25 mar 2017, alle ore 08:21, Lars Melin ha scritto: > > > >> > >> The usb device has been disconnected, why it still cares about VBUS > >> power? > > > > Morphing devices (3G dongles, wifi dongles, some printers) boots up in install mode, usually only as a virtual cd-rom containing Windows drivers and software. > > [...] > > why a host only configured port should cut the VBUS supply, it could be always on right? > > > > Yes, that’s exactly the problem I tried to solve with this patch. Yeah, the problem is clear to me now. > I have to add that the problem was not there with kernels up to > 4.8.17, I started to see it with 4.9 and up. > > By git-bisecting kernel sources, it appears this behaviour has been > introduced by this commit: > > 2f3fd2c5bde1f94513c3dc311ae64494085ec371 It seems this patch changes how OTG_STATE_A_WAIT_VRISE and OTG_STATE_A_WAIT_BCON are used. > > I also agree that, in my opinion, a host only port should never remove > the VBUS supply, as it happens on all the PCs (linux+windows+mac) that > I tested until now. True. It is just that the musb driver handles both dual-role and host-only mode. > > I saw this problem on a beaglebone black. Of course I’m available to > do all the tests that you might suggest me to help you better > understand the issue. Thanks for the offer. Please let me look at the problem first, I have a modem to test. It is not clear why the original driver clears VBUS in this place, so I have to ensure your patch is the correct change. Regards, -Bin.