Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753300AbdC0OSN (ORCPT ); Mon, 27 Mar 2017 10:18:13 -0400 Received: from mail.kernel.org ([198.145.29.136]:60934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752800AbdC0OSF (ORCPT ); Mon, 27 Mar 2017 10:18:05 -0400 Date: Mon, 27 Mar 2017 23:17:15 +0900 From: Masami Hiramatsu To: Ravi Bangoria Cc: acme@redhat.com, alexis.berlemont@gmail.com, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, naveen.n.rao@linux.vnet.ibm.com, mpe@ellerman.id.au, hemant@linux.vnet.ibm.com Subject: Re: [PATCH v2 1/3] perf/sdt/x86: Add renaming logic for (missing) 8 bit registers Message-Id: <20170327231715.cf9a6e2571347157d6266d98@kernel.org> In-Reply-To: <20170327075829.2205-2-ravi.bangoria@linux.vnet.ibm.com> References: <20170327075829.2205-1-ravi.bangoria@linux.vnet.ibm.com> <20170327075829.2205-2-ravi.bangoria@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1647 Lines: 58 On Mon, 27 Mar 2017 13:28:27 +0530 Ravi Bangoria wrote: > I found couple of events using al, bl, cl and dl registers for > argument. These are not directly accepted by uprobe_events and > thus needs to be mapped to ax, bx, cx and dx respectively. > > Few ex, > > /usr/bin/qemu-system-s390x > css_adapter_interrupt: 1@%bl > css_chpid_add: 1@%cl 1@%sil 1@%dl > dma_bdrv_io: 8@%rbx 8@%rbp -8@%r14 1@%al > > /usr/bin/postgres > buffer__read__done: ... -1@-bash -1@%al > buffer__read__start: ... -1@%al Of course, it should be suppoted. BTW, wouldn't we take care about ah, bh ... too? Acked-by: Masami Hiramatsu Thanks! > > Signed-off-by: Ravi Bangoria > --- > tools/perf/arch/x86/util/perf_regs.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/arch/x86/util/perf_regs.c b/tools/perf/arch/x86/util/perf_regs.c > index d8a8dcf..99faab4 100644 > --- a/tools/perf/arch/x86/util/perf_regs.c > +++ b/tools/perf/arch/x86/util/perf_regs.c > @@ -40,12 +40,16 @@ struct sdt_name_reg { > static const struct sdt_name_reg sdt_reg_renamings[] = { > SDT_NAME_REG(eax, ax), > SDT_NAME_REG(rax, ax), > + SDT_NAME_REG(al, ax), > SDT_NAME_REG(ebx, bx), > SDT_NAME_REG(rbx, bx), > + SDT_NAME_REG(bl, ax), > SDT_NAME_REG(ecx, cx), > SDT_NAME_REG(rcx, cx), > + SDT_NAME_REG(cl, ax), > SDT_NAME_REG(edx, dx), > SDT_NAME_REG(rdx, dx), > + SDT_NAME_REG(dl, ax), > SDT_NAME_REG(esi, si), > SDT_NAME_REG(rsi, si), > SDT_NAME_REG(sil, si), > -- > 2.9.3 > -- Masami Hiramatsu