Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753327AbdC0OVB (ORCPT ); Mon, 27 Mar 2017 10:21:01 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:36319 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753213AbdC0OUx (ORCPT ); Mon, 27 Mar 2017 10:20:53 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170324140635.56565-1-andriy.shevchenko@linux.intel.com> <1490365775.21738.7.camel@linux.intel.com> From: Arnd Bergmann Date: Mon, 27 Mar 2017 16:12:58 +0200 X-Google-Sender-Auth: -VAsHoJ297hm_5cXuqK_UJ6wT9k Message-ID: Subject: Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder To: Geert Uytterhoeven Cc: Andy Shevchenko , Miguel Ojeda Sandonis , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Linus Walleij , Willy Tarreau Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 29 On Fri, Mar 24, 2017 at 4:19 PM, Geert Uytterhoeven wrote: > Hi Andy, > > On Fri, Mar 24, 2017 at 3:29 PM, Andy Shevchenko > wrote: >> On Fri, 2017-03-24 at 15:19 +0100, Geert Uytterhoeven wrote: >>> On Fri, Mar 24, 2017 at 3:06 PM, Andy Shevchenko >>> wrote: >>> > It looks like panel.c belongs to auxdisplay subsystem. >>> > >>> > Move it to drivers/auxdisplay folder. >>> > No functional changes intended. >>> >>> I didn't move it to drivers/auxdisplay/ because it not only provides >>> auxdisplay functionality, but also keypad functionality. >> >> Yes, I have noticed this. But keypad functionality is optional while >> panel is main one. I think you would agree on this. > > I don't care that much, though. Willy? I think moving all of it to drivers/auxdisplay as it is today, and doing any further cleanup on the driver over there is a good idea. On a related note, how about moving arm-charlcd there as well, and finding a new place for the various ALS drivers? Arnd