Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753285AbdC0Ogx (ORCPT ); Mon, 27 Mar 2017 10:36:53 -0400 Received: from smtp5-g21.free.fr ([212.27.42.5]:42240 "EHLO smtp5-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752607AbdC0Ogn (ORCPT ); Mon, 27 Mar 2017 10:36:43 -0400 Subject: Re: [RFC PATCH v0.2] PCI: Add support for tango PCIe host bridge To: Marc Zyngier Cc: Bjorn Helgaas , Thomas Gleixner , Robin Murphy , Lorenzo Pieralisi , Liviu Dudau , David Laight , linux-pci , Linux ARM , Thibaud Cornic , Phuong Nguyen , LKML References: <91db1f47-3024-9712-309a-fb4b21e42028@free.fr> <310db9dd-7db6-2106-2e53-f0083b2d3758@free.fr> <9fffedd4-6292-b662-a588-a68fe7380af6@free.fr> <6e847686-43c6-11e9-6782-dec0fe81a58e@arm.com> From: Mason Message-ID: <9c65e647-8395-4467-53ca-c20ed374131b@free.fr> Date: Mon, 27 Mar 2017 16:35:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0 SeaMonkey/2.48 MIME-Version: 1.0 In-Reply-To: <6e847686-43c6-11e9-6782-dec0fe81a58e@arm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 448 Lines: 14 On 24/03/2017 19:22, Marc Zyngier wrote: > You cannot directly use a pointer to a u32 in any of the bitmap > operations. You need to copy the value to an unsigned long, and > apply the bitmap op on that. On my platform, find_first_zero_bit() resolves to int _find_first_zero_bit_le(const void * p, unsigned size); If the underlying implementation actually expects an unsigned long pointer, should the function prototype be changed? Regards.