Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752799AbdC0O67 (ORCPT ); Mon, 27 Mar 2017 10:58:59 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:38209 "EHLO mail-it0-f49.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752336AbdC0O6u (ORCPT ); Mon, 27 Mar 2017 10:58:50 -0400 Message-ID: <1490626683.5935.18.camel@ndufresne.ca> Subject: Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files From: Nicolas Dufresne To: Hans Verkuil , Stanimir Varbanov , Mauro Carvalho Chehab Cc: Andy Gross , Bjorn Andersson , Stephen Boyd , Srinivas Kandagatla , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Date: Mon, 27 Mar 2017 10:58:03 -0400 In-Reply-To: <6ea4524d-9794-a9b5-8327-367152c92493@xs4all.nl> References: <1489423058-12492-1-git-send-email-stanimir.varbanov@linaro.org> <1489423058-12492-6-git-send-email-stanimir.varbanov@linaro.org> <52b39f43-6f70-0cf6-abaf-4bb5bd2b3d86@xs4all.nl> <6ea4524d-9794-a9b5-8327-367152c92493@xs4all.nl> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-hJgOGKCnhgucUo3AG8si" X-Mailer: Evolution 3.22.5 (3.22.5-1.fc25) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 40 --=-hJgOGKCnhgucUo3AG8si Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le lundi 27 mars 2017 =C3=A0 10:45 +0200, Hans Verkuil a =C3=A9crit=C2=A0: > > > timestamp and sequence are only set for CAPTURE, not OUTPUT. Is > > > that correct? > >=20 > > Correct. I can add sequence for the OUTPUT queue too, but I have no > > idea how that sequence is used by userspace. >=20 > You set V4L2_BUF_FLAG_TIMESTAMP_COPY, so you have to copy the > timestamp from the output buffer > to the capture buffer, if that makes sense for this codec. If not, > then you shouldn't use that > V4L2_BUF_FLAG and just generate new timestamps whenever a capture > buffer is ready. >=20 > For sequence numbering just give the output queue its own sequence > counter. Btw, GStreamer and Chromium only supports TIMESTAMP_COPY, and will most likely leak frames if you craft timestamp. Nicolas --=-hJgOGKCnhgucUo3AG8si Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAljZKHsACgkQcVMCLawGqByoUgCbBp7XbvkFYcKl9sYQ2TdzP1LE mRwAnjUd2J0Bf3baPl+9SXDQa8YZAXkL =k7fQ -----END PGP SIGNATURE----- --=-hJgOGKCnhgucUo3AG8si--