Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751451AbdC0Q5X (ORCPT ); Mon, 27 Mar 2017 12:57:23 -0400 Received: from mail-pg0-f50.google.com ([74.125.83.50]:35214 "EHLO mail-pg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbdC0Q5Q (ORCPT ); Mon, 27 Mar 2017 12:57:16 -0400 Date: Mon, 27 Mar 2017 09:56:31 -0700 From: Brian Norris To: Thierry Escande Cc: Rob Herring , Greg Kroah-Hartman , Olof Johansson , Stephen Warren , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Julius Werner Subject: Re: [PATCH 5/5] firmware: google memconsole: Add ARM/ARM64 support Message-ID: <20170327165630.GA128943@google.com> References: <1490303069-13230-1-git-send-email-thierry.escande@collabora.com> <1490303069-13230-6-git-send-email-thierry.escande@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490303069-13230-6-git-send-email-thierry.escande@collabora.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1514 Lines: 47 Hi Thierry, In case this wasn't obvious from the build report: On Thu, Mar 23, 2017 at 10:04:29PM +0100, Thierry Escande wrote: > --- a/drivers/firmware/google/Kconfig > +++ b/drivers/firmware/google/Kconfig > @@ -1,6 +1,5 @@ > menuconfig GOOGLE_FIRMWARE > bool "Google Firmware Drivers" > - depends on X86 The build bots complained: you're relaxing the compile-time restriction here, so you should probably move it to the GOOGLE_SMI symbol, since that file uses X86 assembly. > default n > help > These firmware drivers are used by Google's servers. They are > @@ -21,7 +20,7 @@ config GOOGLE_SMI > > config GOOGLE_COREBOOT_TABLE > tristate > - depends on GOOGLE_COREBOOT_TABLE_ACPI > + depends on GOOGLE_COREBOOT_TABLE_ACPI || GOOGLE_COREBOOT_TABLE_OF > > config GOOGLE_COREBOOT_TABLE_ACPI > tristate "Coreboot Table Access - ACPI" > @@ -33,6 +32,16 @@ config GOOGLE_COREBOOT_TABLE_ACPI > pointer is accessed through the ACPI "GOOGCB00" object. > If unsure say N. > > +config GOOGLE_COREBOOT_TABLE_OF > + tristate "Coreboot Table Access - Device Tree" > + depends on OF > + select GOOGLE_COREBOOT_TABLE > + help > + This option enable the coreboot_table module, which provide other > + firmware modules to access coreboot table. The coreboot table pointer > + is accessed through the device tree node /firmware/coreboot. > + If unsure say N. > + > config GOOGLE_MEMCONSOLE > tristate > depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT Brian