Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751867AbdC0RMz (ORCPT ); Mon, 27 Mar 2017 13:12:55 -0400 Received: from relmlor3.renesas.com ([210.160.252.173]:40173 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751367AbdC0RMc (ORCPT ); Mon, 27 Mar 2017 13:12:32 -0400 X-IronPort-AV: E=Sophos;i="5.36,232,1486393200"; d="scan'208";a="237884425" From: Chris Brandt To: Jacopo Mondi , "geert+renesas@glider.be" , "laurent.pinchart@ideasonboard.com" , "linus.walleij@linaro.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux@armlinux.org.uk" CC: "linux-renesas-soc@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node Thread-Topic: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node Thread-Index: AQHSpLJ+mlNpKn5BY0S+/bqQWBmg66Go6Lew Date: Mon, 27 Mar 2017 17:12:04 +0000 Message-ID: References: <1490368934-12494-1-git-send-email-jacopo+renesas@jmondi.org> <1490368934-12494-5-git-send-email-jacopo+renesas@jmondi.org> In-Reply-To: <1490368934-12494-5-git-send-email-jacopo+renesas@jmondi.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: jmondi.org; dkim=none (message not signed) header.d=none;jmondi.org; dmarc=none action=none header.from=renesas.com; x-originating-ip: [4.59.13.106] x-microsoft-exchange-diagnostics: 1;SG2PR06MB1167;7:O0lSFH7SIfPuRsBM6UuvLoVxsB1jTHOtt69tbQ4+9/LUhqe5dkdGjhL8CIJWQVWK5XNXRrBhywuDNgsfKf9Ucb4hcRsvBX9diTUe1chyQHel7N86pPYpzW9Sb0pY7SxWJeeh3dVlxYn/mINhjxUwuqiiNc1N2MRTFpOf1S5Fjien0/BZc8DZl/Fr41RrNO2jLhA7EAEeUG4tXbJ3nVlXj+4SuouRpuNIpENTXzs2Y5UXOTR3h2co8vio1kO2JnxJmigIZRwdn+ZW+Df+L0Tc/9yIB71+h+wFCeamOfhEo7VO8GJlVSVcI7uT5Yvos1P7yMF4x8eIAhqPoICEBekouA==;20:eItkoyvn+tOHLt4XQb1CHW1OvS2SUyGY0M4oY21yOfBYYaOUpZ+ErR7W/rqZ+KhjLcCPezIjmUMsIgUUbGOTvgg9D11BgUaxmaYXILwzAVoV8AdWHqnj9QqZhXUBKpkiFxdgwV/JSC+TVK3aroM7WWXTPA/UlWo7NGdmbEH9vbE= x-ms-office365-filtering-correlation-id: 59e92fdc-bd41-41c4-cfe7-08d475346425 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081);SRVR:SG2PR06MB1167; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123564025)(20161123555025)(20161123558025)(20161123560025)(6072148);SRVR:SG2PR06MB1167;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB1167; x-forefront-prvs: 02596AB7DA x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39410400002)(39860400002)(39840400002)(39450400003)(39850400002)(7696004)(76176999)(50986999)(54356999)(86362001)(6246003)(189998001)(7736002)(122556002)(2950100002)(6436002)(2906002)(77096006)(38730400002)(25786009)(8936002)(3660700001)(7416002)(6506006)(5660300001)(33656002)(2900100001)(8676002)(66066001)(229853002)(81166006)(4326008)(9686003)(2501003)(6116002)(74316002)(3846002)(102836003)(53936002)(99286003)(55016002)(3280700002)(305945005)(54906002);DIR:OUT;SFP:1102;SCL:1;SRVR:SG2PR06MB1167;H:SG2PR06MB1165.apcprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2017 17:12:04.2819 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB1167 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2RHDEJ9018162 Content-Length: 480 Lines: 18 Hi Jacopo, On Friday, March 24, 2017, Jacopo Mondi > + pinctrl: pinctrl@fcfe3000 { > + compatible = "renesas,r7s72100-ports"; > + > + #pinctrl-cells = <1>; > + > + reg = <0xfcfe3000 0x42C0>; Out of curiosity, why did you change this from 0x4248 to 0x42C0? In your update for renesas,rza1-pinctrl.txt, for the 'Example', you changed it from 0x4248 to 0x4230 (which Geert pointed out makes more sense), but then in the actual DT file you changed it to 0x42C0. Typo? Chris